chore: test shared maestro actions from WalletConnect/actions by ignaciosantise · Pull Request #461 · reown-com/react-native-examples

ignaciosantise · 2026-04-07T18:50:45Z

Summary

Point ci_e2e_walletkit.yaml at the shared Maestro composite actions from WalletConnect/actions@feat/maestro-pay-actions (feat(maestro): shared WalletConnect Pay E2E test actions WalletConnect/actions#77)
iOS job uses all 3 shared actions: maestro/pay-tests, maestro/setup, maestro/run
Android job uses maestro/pay-tests and maestro/setup before the emulator runner, keeps inline maestro test in the script block

Purpose

This is a validation PR to confirm the shared actions work end-to-end before merging WalletConnect/actions#77 to master. Once validated, the action refs will be updated from @feat/maestro-pay-actions to @master.

Test plan

Trigger workflow_dispatch for iOS — confirm shared flows are copied, Maestro installs, tests pass
Trigger workflow_dispatch for Android — confirm same
Verify artifacts upload correctly

🤖 Generated with Claude Code

Point CI E2E workflow at WalletConnect/actions/maestro/* composite actions (feat/maestro-pay-actions branch) to test the shared Pay test flows. - iOS: uses maestro/pay-tests, maestro/setup, and maestro/run actions - Android: uses maestro/pay-tests and maestro/setup before emulator runner, keeps inline maestro test command in the script block Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

vercel · 2026-04-07T18:50:50Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
pos-demo	Ready	Preview, Comment	Apr 7, 2026 7:44pm

claude · 2026-04-07T18:51:11Z

Claude finished @ignaciosantise's task in 1m 40s —— View job

Code Review

No breaking changes or data classification issues found.

Found 2 issue(s)

Issue 1: Mutable action ref will need update before production merge

ID: ci-e2e-walletkit-mutable-action-ref-a3f1
File: .github/workflows/ci_e2e_walletkit.yaml:140,143,147,287,290
Severity: MEDIUM
Category: security

Context:

Pattern: All three action references use @feat/maestro-pay-actions — a mutable branch ref
Risk: Branch refs can be force-pushed or repointed; any change to WalletConnect/actions@feat/maestro-pay-actions will silently affect this workflow on next run
Impact: Unexpected behavior changes or supply-chain risk if the branch is tampered with
Trigger: Noted as intentional for this validation PR; must be updated to @master (or a pinned SHA) before merging to main

Recommendation: After validation, pin to a SHA or the stable @master ref:

uses: WalletConnect/actions/maestro/pay-tests@<SHA>

Issue 2: Android script hardcodes absolute Maestro binary path

ID: ci-e2e-walletkit-android-hardcoded-maestro-path-b7c2
File: .github/workflows/ci_e2e_walletkit.yaml:309
Severity: LOW
Category: code_quality

Context:

Pattern: $HOME/.maestro/bin/maestro test ... — uses absolute path inside the emulator runner script
Risk: The maestro/setup composite action adds $HOME/.maestro/bin to $GITHUB_PATH for subsequent steps, but inside reactivecircus/android-emulator-runner's script: block the PATH update from a prior step may or may not apply. More importantly, if the setup action ever changes the install location, this hardcode silently breaks
Impact: Workflow failure if install path diverges from assumption
Trigger: Whenever WalletConnect/actions/maestro/setup changes its install directory

Recommendation: Rely on the PATH addition from the setup action and remove the absolute prefix:

script: |
  adb install ...
  maestro test --env APP_ID=...

github-actions · 2026-04-07T18:53:12Z

.github/workflows/ci_e2e_walletkit.yaml

      - name: Install app on Simulator
        run: xcrun simctl install "$DEVICE_ID" "$APP_PATH"

+      - name: Copy shared Pay test flows


🤖 Auto Review Issue: Mutable action ref will need update before production merge

Severity: MEDIUM
Category: security
Tool: Claude Auto Review

Context:

Pattern: All three action references use @feat/maestro-pay-actions — a mutable branch ref

Risk: Branch refs can be force-pushed or repointed; any change to WalletConnect/actions@feat/maestro-pay-actions will silently affect this workflow on next run

Impact: Unexpected behavior changes or supply-chain risk if the branch is tampered with

Trigger: Noted as intentional for this validation PR; must be updated to @master (or a pinned SHA) before merging to main

Recommendation: After validation, pin to a SHA or the stable @master ref:

uses: WalletConnect/actions/maestro/pay-tests@<SHA>

Copilot

Pull request overview

Updates the WalletKit E2E GitHub Actions workflow to validate running Maestro pay tests via shared composite actions hosted in WalletConnect/actions, as a precursor to merging those shared actions upstream.

Changes:

Switched iOS job from inline Maestro install/test commands to shared maestro/pay-tests, maestro/setup, and maestro/run actions.
Switched Android job Maestro installation + shared pay flows to shared maestro/pay-tests and maestro/setup actions (keeping inline maestro test under the emulator runner).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-07T18:53:23Z

.github/workflows/ci_e2e_walletkit.yaml

+      - name: Copy shared Pay test flows
+        uses: WalletConnect/actions/maestro/pay-tests@feat/maestro-pay-actions
+
      - name: Install Maestro
-        run: |
-          curl -fsSL "https://get.maestro.mobile.dev" | bash
-          echo "$HOME/.maestro/bin" >> "$GITHUB_PATH"
+        uses: WalletConnect/actions/maestro/setup@feat/maestro-pay-actions

      - name: Run Maestro tests
        id: maestro
-        run: |
-          set -o pipefail
-          maestro test \
-            --env APP_ID="${{ env.MAESTRO_APP_ID }}" \
-            --env WPAY_CUSTOMER_KEY_MULTI_KYC="${{ secrets.WPAY_CUSTOMER_KEY_MULTI_KYC }}" \
-            --env WPAY_MERCHANT_ID_MULTI_KYC="${{ secrets.WPAY_MERCHANT_ID_MULTI_KYC }}" \
-            --env WPAY_CUSTOMER_KEY_MULTI_NOKYC="${{ secrets.WPAY_CUSTOMER_KEY_MULTI_NOKYC }}" \
-            --env WPAY_MERCHANT_ID_MULTI_NOKYC="${{ secrets.WPAY_MERCHANT_ID_MULTI_NOKYC }}" \
-            --env WPAY_CUSTOMER_KEY_SINGLE_NOKYC="${{ secrets.WPAY_CUSTOMER_KEY_SINGLE_NOKYC }}" \
-            --env WPAY_MERCHANT_ID_SINGLE_NOKYC="${{ secrets.WPAY_MERCHANT_ID_SINGLE_NOKYC }}" \
-            --include-tags "${{ env.MAESTRO_TAGS }}" \
-            --test-output-dir maestro-artifacts \
-            --debug-output maestro-artifacts \
-            .maestro/ 2>&1 | tee maestro-output.log
-
-      - name: Upload Maestro artifacts
-        if: always()
-        uses: actions/upload-artifact@v4
+        uses: WalletConnect/actions/maestro/run@feat/maestro-pay-actions


These steps reference WalletConnect/actions using a mutable branch ref (@feat/maestro-pay-actions) while also passing secrets into the action inputs. For supply-chain safety and reproducibility, pin the action to a commit SHA (even during validation), then update the pinned SHA (or switch to a tag) when the shared actions are merged.

Copilot · 2026-04-07T18:53:24Z

.github/workflows/ci_e2e_walletkit.yaml

+          wpay-customer-key-multi-kyc: ${{ secrets.WPAY_CUSTOMER_KEY_MULTI_KYC }}
+          wpay-merchant-id-multi-kyc: ${{ secrets.WPAY_MERCHANT_ID_MULTI_KYC }}
+          artifact-name: maestro-ios-artifacts



The previous workflow always uploaded Maestro logs/artifacts via a dedicated actions/upload-artifact step (with if: always()). Now iOS artifact handling is delegated entirely to the external maestro/run action. Please ensure that action uploads artifacts even when the Maestro run fails (i.e., uses if: always() internally), or reintroduce an explicit upload-artifact step here so failure cases still produce logs for debugging.

Suggested change

- name: Upload Maestro iOS artifacts

if: always()

uses: actions/upload-artifact@v4

with:

name: maestro-ios-artifacts-fallback

if-no-files-found: ignore

path: |

~/.maestro/tests/**

~/.maestro/logs/**

.maestro/**

Copilot · 2026-04-07T18:53:24Z

.github/workflows/ci_e2e_walletkit.yaml

+      - name: Copy shared Pay test flows
+        uses: WalletConnect/actions/maestro/pay-tests@feat/maestro-pay-actions
+
      - name: Install Maestro
-        run: |
-          curl -fsSL "https://get.maestro.mobile.dev" | bash
-          echo "$HOME/.maestro/bin" >> "$GITHUB_PATH"
+        uses: WalletConnect/actions/maestro/setup@feat/maestro-pay-actions


Same concern as iOS: these steps use a mutable branch ref (@feat/maestro-pay-actions) for an external action. Pin to a commit SHA to avoid the workflow behavior changing unexpectedly between runs and to reduce supply-chain risk.

Pay test flows now live in WalletConnect/actions repo as the single source of truth. Added scripts/setup-maestro-pay-tests.sh to download them for local development. CI uses the maestro/pay-tests composite action to copy them at build time. The .gitignore prevents downloaded pay flows from being committed. Usage: ./scripts/setup-maestro-pay-tests.sh [branch] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Reads WPAY secrets from .env.maestro file and passes them to maestro. Usage: cp .env.maestro.example .env.maestro # fill in secrets ./scripts/setup-maestro-pay-tests.sh # download flows ./scripts/run-maestro-pay-tests.sh # run all pay tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Process substitution with source <(...) doesn't export variables properly in all bash contexts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The run script now automatically downloads shared test flows from WalletConnect/actions if they're not already present. No need to run setup-maestro-pay-tests.sh separately. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings April 7, 2026 18:50

Copilot started reviewing on behalf of ignaciosantise April 7, 2026 18:51 View session

vercel bot deployed to Preview – pos-demo April 7, 2026 18:52 View deployment

github-actions bot reviewed Apr 7, 2026

View reviewed changes

Copilot AI reviewed Apr 7, 2026

View reviewed changes

ignaciosantise marked this pull request as draft April 7, 2026 19:27

ignaciosantise requested a review from jakubuid April 7, 2026 19:27

vercel bot deployed to Preview – pos-demo April 7, 2026 19:35 View deployment

vercel bot deployed to Preview – pos-demo April 7, 2026 19:37 View deployment

fix: source .env.maestro directly instead of via process substitution

190f8a3

Process substitution with source <(...) doesn't export variables properly in all bash contexts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

vercel bot deployed to Preview – pos-demo April 7, 2026 19:42 View deployment

chore: auto-download pay flows in run script

9360b24

The run script now automatically downloads shared test flows from WalletConnect/actions if they're not already present. No need to run setup-maestro-pay-tests.sh separately. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

vercel bot deployed to Preview – pos-demo April 7, 2026 19:44 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: test shared maestro actions from WalletConnect/actions#461

chore: test shared maestro actions from WalletConnect/actions#461
ignaciosantise wants to merge 5 commits intomainfrom
feat/maestro-pay-actions

ignaciosantise commented Apr 7, 2026 •

edited

Loading

Uh oh!

vercel bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

claude bot commented Apr 7, 2026 •

edited

Loading

Issue 1: Mutable action ref will need update before production merge

Issue 2: Android script hardcodes absolute Maestro binary path

Uh oh!

github-actions bot Apr 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

+      - name: Upload Maestro iOS artifacts
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: maestro-ios-artifacts-fallback
+          if-no-files-found: ignore
+          path: |
+            ~/.maestro/tests/**
+            ~/.maestro/logs/**
+            .maestro/**

Conversation

ignaciosantise commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Purpose

Test plan

Uh oh!

vercel bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review

Issue 1: Mutable action ref will need update before production merge

Issue 2: Android script hardcodes absolute Maestro binary path

Uh oh!

github-actions bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ignaciosantise commented Apr 7, 2026 •

edited

Loading

vercel bot commented Apr 7, 2026 •

edited

Loading

claude bot commented Apr 7, 2026 •

edited

Loading