Improve foreach docs examples#6562
Conversation
Greptile SummaryThis PR improves the
Confidence Score: 4/5The content changes are solid, but the frontmatter removal drops the auto-generated component API table that every other docs page in the library section relies on. Cross-checking five other component docs pages (box, aspect_ratio, center, card, html/text) confirms they all keep the components frontmatter block so the docs system can embed the full prop reference. Stripping it from foreach.md means readers lose that auto-generated table, and depending on how the docs build uses the key, it may also break search indexing or the component registry for this page. docs/library/dynamic-rendering/foreach.md — the removed YAML frontmatter and the inaccurate iterable-type list in the manual API Reference section both need a second look before merging. Important Files Changed
Reviews (2): Last reviewed commit: "Address foreach docs review comments" | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing |
|
Updated the complex dictionary example layout after local review: it now renders the three secondary colors as three grouped columns with spacing instead of wrapping the third group underneath. |
|
Updated the color examples again after visual review: they now use explicit site-friendly hex colors and a shared rounded |
|
Simplified the swatch examples after review: the basic color example is back to |
masenf
left a comment
There was a problem hiding this comment.
The API Reference at the bottom of this page seems weird. It only shows the iterable prop, which mismatches with how the foreach component is supposed to be used.
|
@greptile |
Summary
rx.foreachversus Python comprehensionsrx.Var[...]finish_itemas an event handlerTesting
CI=1and whitelisted/library/dynamic-rendering/foreachhttp://localhost:3000/docs/library/dynamic-rendering/foreach/Donebutton removes an item from the rendered listgit diff --check