fix: reconnect port forwarding if pod is restarted (crw-11119)#314
Draft
adietish wants to merge 6 commits into
Draft
fix: reconnect port forwarding if pod is restarted (crw-11119)#314adietish wants to merge 6 commits into
adietish wants to merge 6 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
adietish
force-pushed
the
crw-11119
branch
4 times, most recently
from
580461c to
5f8f48e
Compare
Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…pod roll - Add retry loop (maxRetries, retryDelay) for transient failures during pod roll reconnect; permanent failures fail immediately. - Distinguish TimeoutCancellationException from cancellation exceptions: retry it, propagate cancellation exceptions. - Updated logging to reflect retry attempt count and omit stack trace for timeout failures. - Rename readyTimeout -> READY_TIMEOUT (constant), double value 60->120s. - Add cachePod() to seed cache without cluster query during pod roll. - Update findFirstRunning() to return newest pod by creationTimestamp and exclude terminating pods (deletionTimestamp). - Add comprehensive tests for retry, timeout, permanent failure, and cancellation scenarios.
Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
coroutineScope waited for launchCancelWatcher to exit; progress stayed open until the user cancelled. Stop the watcher when auth completes. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
adietish
force-pushed
the
crw-11119
branch
3 times, most recently
from
ee9f641 to
f0d35ec
Compare
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://redhat.atlassian.net/browse/CRW-11119