[Sample] Fix samples - #5154
Conversation
46d4f23 to
faf1066
Compare
faf1066 to
aebc8d9
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit aebc8d9. Configure here.
| memory: "2Gi" | ||
| requests: | ||
| cpu: "200m" | ||
| memory: "2Gi" |
There was a problem hiding this comment.
Head memory limit reduced incorrectly
Medium Severity
The head container memory limit was lowered from 5Gi to 2Gi while adding a 2Gi request. The cited ray-job.sample.yaml keeps limit 5Gi and request 2Gi, and sibling samples like ray-cronjob-timezone.sample.yaml still use a 5Gi head limit. A tighter limit can OOM the Ray head (GCS/dashboard) for users following this sample.
Reviewed by Cursor Bugbot for commit aebc8d9. Configure here.
There was a problem hiding this comment.
cc @machichima to also fix the ray-cronjob-timezone.sample.yaml.
There was a problem hiding this comment.
Thank you! Updated
| memory: "2Gi" | ||
| requests: | ||
| cpu: "200m" | ||
| memory: "2Gi" |
There was a problem hiding this comment.
cc @machichima to also fix the ray-cronjob-timezone.sample.yaml.
Signed-off-by: machichima <nary12321@gmail.com>
aebc8d9 to
ca4241c
Compare
Signed-off-by: machichima <nary12321@gmail.com>


Why are these changes needed?
Found some bug in the sample yaml file while testing with
v1.7.0-rc.0. This is the PR updating those YAML files.ray-cronjob.sample.yaml: didn't set request, so it will use up to5Gi(limit). Set request and limit to2Gi(this value comes fromray-job.sample.yaml)kuberay/ray-operator/config/samples/ray-job.sample.yaml
Lines 66 to 68 in 46d4f23
ray-cluster.kubernetes.auth.yamlandray-cluster.kubernetes.auth-manual.yaml: set to newest ray image (2.57.0) rather than nightlyUpdate
ray-cluster.embedded-gcs-ft.yamlto use newest ray image2.57.0as this feature is added in2.57rather than2.52ray-operator/config/samples/ray-cluster.head-command.yamlcomment link to markdown file that does not exists, remove the commentRelated issue number
Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Manual test instructions