Skip to content

[Sample] Fix samples - #5154

Merged
andrewsykim merged 2 commits into
ray-project:masterfrom
machichima:1.7-fix-sample
Aug 19, 2026
Merged

[Sample] Fix samples#5154
andrewsykim merged 2 commits into
ray-project:masterfrom
machichima:1.7-fix-sample

Conversation

@machichima

@machichima machichima commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Why are these changes needed?

Found some bug in the sample yaml file while testing with v1.7.0-rc.0. This is the PR updating those YAML files.

  1. ray-cronjob.sample.yaml: didn't set request, so it will use up to 5Gi (limit). Set request and limit to 2Gi (this value comes from ray-job.sample.yaml)

    requests:
    cpu: "1"
    memory: "2Gi"

  2. ray-cluster.kubernetes.auth.yaml and ray-cluster.kubernetes.auth-manual.yaml: set to newest ray image (2.57.0) rather than nightly

  3. Update ray-cluster.embedded-gcs-ft.yaml to use newest ray image 2.57.0 as this feature is added in 2.57 rather than 2.52

  4. ray-operator/config/samples/ray-cluster.head-command.yaml comment link to markdown file that does not exists, remove the comment

Related issue number

Labels

  • If this PR has user-facing changes that require documentation updates at release time, I have added the doc-updates-required label.
  • If this PR contains breaking changes, I have added the breaking-change label.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Manual test instructions

Comment thread ray-operator/config/samples/ray-cluster.kubernetes.auth.yaml

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit aebc8d9. Configure here.

memory: "2Gi"
requests:
cpu: "200m"
memory: "2Gi"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Head memory limit reduced incorrectly

Medium Severity

The head container memory limit was lowered from 5Gi to 2Gi while adding a 2Gi request. The cited ray-job.sample.yaml keeps limit 5Gi and request 2Gi, and sibling samples like ray-cronjob-timezone.sample.yaml still use a 5Gi head limit. A tighter limit can OOM the Ray head (GCS/dashboard) for users following this sample.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit aebc8d9. Configure here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @machichima to also fix the ray-cronjob-timezone.sample.yaml.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Updated

memory: "2Gi"
requests:
cpu: "200m"
memory: "2Gi"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @machichima to also fix the ray-cronjob-timezone.sample.yaml.

Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
@andrewsykim
andrewsykim merged commit feeaf72 into ray-project:master Aug 19, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants