[v1.7.x] Label Templates: improve Random family processing#915
Merged
fgiudici merged 2 commits intorancher:v1.7.xfrom Jun 13, 2025
Merged
[v1.7.x] Label Templates: improve Random family processing#915fgiudici merged 2 commits intorancher:v1.7.xfrom
fgiudici merged 2 commits intorancher:v1.7.xfrom
Conversation
This commit fixes the panic occurring with a malformed Random
template label (${Random}).
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
A wrong Random label syntax causes a syntax error that fails and stops the registration process: don't stop the registration, just log the error, skip the label and proceed. Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
frelon
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix checking malformed Random template vars (i.e., ${Random}) and avoid failing the whole registration when illegal Random template values are detected: in this case just log an error and skip that specific label only.
Port of #914