feat(discover-v2): scaffold featured markets carousel placements by DanielSinclair · Pull Request #7417 · rainbow-me/rainbow

DanielSinclair · 2026-04-30T08:42:56Z

APP-3670

What changed

Removes the old Perps/Predictions feature cards from the Trending section
Adds MarketCarousel — a generic horizontal FlatList with shimmer skeleton loading, a "See all" action, and variable-width item support
DiscoverHome subscribes to useDiscoverPlacementAvailabilityStore and renders a MarketCarousel section for each active placement type; shows MarketCarousel skeleton slots while placement data is loading
Actual card components land in Android renaming #5 (Perps) and Add spinner for fetching transactions #7 (Predictions) — link once PRs are open

Screen recordings / screenshots

What to test

Old Perps/Predictions feature cards are gone from Trending
With placements enabled: shimmer placeholder rows visible for Perps and Predictions
With placements disabled or on testnet: sections hidden; existing Trending Tokens, mints, learn cards unaffected

DanielSinclair · 2026-04-30T08:51:19Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91c9a66f8d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-30T08:54:04Z

+  const showPerpsPlacement = availability.perps && isLoading;
+  const showPredictionsPlacement = availability.predictions && isLoading;
+  const showPlacements = showPerpsPlacement || showPredictionsPlacement;


Keep placement sections rendered after fetch completes

showPerpsPlacement and showPredictionsPlacement are gated on isLoading, so both sections are unmounted as soon as usePlacementsStore reaches success (or when cached state hydrates as non-loading). In practice this means enabled placements are only visible during a short loading window and can disappear permanently for warm-cache users, which defeats the carousel placement surface this change is introducing.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-30T08:54:04Z

+                  itemHeight={CARD_HEIGHT}
+                  itemWidth={CARD_WIDTH}
+                  renderItem={(_item, _helpers) => <Box />}
+                  onSeeAll={() => undefined}


Remove dead “See all” CTA until navigation exists

Both placement carousels render a visible “See all” action but pass onSeeAll={() => undefined}, so taps do nothing besides analytics. For users with placements enabled, this exposes a non-functional primary affordance and creates a dead-end interaction; the button should be hidden/disabled until a destination is wired.

Useful? React with 👍 / 👎.

github-actions · 2026-04-30T09:28:25Z

🧪 Flashlight Performance Report (AWS Device Farm)

🔀 Commit: 3133b38

📎 View Artifacts

Metric	Current	Δ vs Baseline
Time to Interactive (TTI)	5599 ms	–
Average FPS	56.52	–
Average RAM	395.5 MB	–

github-actions · 2026-04-30T10:34:52Z

Launch in simulator or device for bdb8dec

Clears out the old Perps/Predictions feature card surfaces before the new placement carousels are introduced.

Pure path migration — isolated so reviewers see only the move.

Generic horizontal carousel component with shimmer skeleton loading, See All button, analytics trackPress slot, and variable-width item support. Used by both Perps and Predictions placements.

Adds Perps and Predictions carousel sections to DiscoverHome driven by the availability store. Renders skeleton placeholders while placement data loads; sections are hidden once loaded since composition stores land in the domain branches.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6bbfc95b47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-30T11:46:51Z

+
+  const testNetwork = useSyncDiscoverPlacementAvailabilityNetwork();
+  const availability = useDiscoverPlacementAvailability();
+  const isLoading = usePlacementsStore(state => state.status === 'loading' || state.status === 'idle');


Gate placements store subscription behind availability

usePlacementsStore is subscribed unconditionally, so createQueryStore will still kick off a placements fetch even when placements can never be shown (for example on testnet, or when discover_placements_enabled is off). This introduces unnecessary Firestore traffic and background work on every Discover visit in those environments; the subscription/fetch should be conditioned on placement availability instead of always mounting.

Useful? React with 👍 / 👎.

github-actions · 2026-04-30T12:17:43Z

Launch in simulator or device for 3133b38

ibrahimtaveras00

Looks good on both OS's ✅

maxbbb · 2026-05-01T18:42:46Z

+        analytics.track(event.discoverPlacementCardPressed, {
+          placementId,
+          placementScreen: placement?.screen,
+          placementTitle: title,
+          itemOrder: item.order,
+          marketId,
+          marketName,
+          marketSlug,
+          marketSymbol,
+          marketType: item.ref.source,
+        });


I'm not sure much is gained here vs. just passing in the whole placement object as a "placement" field. If you want to query this data in amplitude you're going to want to separate out the top level type (perps vs. polymarket) anyway, so attempting to normalize the data here and committing to do that for all future iterations seems not necessary. Open to hearing if there is an argument for this shape though.

Would also allow us to have just one event "placementCardPressed" that would work on other future screens (since placements have a "screen" field).

maxbbb · 2026-05-01T18:44:03Z

+      return <View style={{ width: itemWidths[index] ?? itemWidth }}>{renderItem(item, { trackPress })}</View>;
+    },
+    [itemWidth, itemWidths, placement, placementId, renderItem, title]
+  );


This whole trackPress pattern is not ideal imo. Would be much cleaner to let the individual components own the onPress or to just wrap the view here in a <ButtonPressAnimation> and adding a pressProps prop if you want to let consumers customize the scaleTo or anything else (which I don't think we even need).

maxbbb · 2026-05-01T18:46:59Z

+          ))}
+        </View>
+      ) : (
+        <Animated.FlatList


We're not using animated animated props, should just be a normal FlatList

maxbbb · 2026-05-01T18:49:45Z

+  contentContainer: {
+    paddingHorizontal: CAROUSEL_HORIZONTAL_PADDING,
+  },


You can just put gap: CARD_GAP here and remove all the ItemSeparatorComponent related logic.

maxbbb · 2026-05-01T18:51:49Z

+  getItemWidth?: (item: T) => number;
+  keyExtractor: (item: T) => string;
+  loading?: boolean;
+  onSeeAll: () => void;


Would make the prop name clear that it's a press event (ie onPressSeeAll)

maxbbb · 2026-05-01T18:55:52Z

+  itemHeight?: number;
+  itemWidth?: number;
+  getItemWidth?: (item: T) => number;
+  keyExtractor: (item: T) => string;


For any prop types that are meant to be directly drilled to the list, I would prefer using the list props directly through = Pick<FlatListProps<T>, 'data' | 'keyExtractor'> & { other props }

maxbbb · 2026-05-01T19:02:41Z

+
+export const HORIZONTAL_PADDING = 20;
+
+const keyExtractor = (item: PlacementItem) => `${item.ref.source}:${item.ref.id}`;


prefer function keyExtractor declaration for module level definitions.

maxbbb · 2026-05-04T17:42:28Z

+              {showPerpsPlacement && (
+                <MarketCarousel
+                  title={i18n.t(i18n.l.discover.placements.perps_title)}
+                  placementId={PLACEMENT_IDS.PERPS}
+                  data={[] as PlacementItem[]}
+                  keyExtractor={keyExtractor}
+                  itemHeight={CARD_HEIGHT}
+                  itemWidth={CARD_WIDTH}
+                  renderItem={(_item, _helpers) => <Box />}
+                  onSeeAll={() => undefined}
+                  loading={isLoading}
+                />
+              )}


I know not the general pattern in this file (it's pretty old) but it would better to put the specific placement logic into its own components, so in this case PerpsMarketCarousel that subscribes to the state needed to decided if it should render, and just return null if not. Same thing for the predictions carousel.

DanielSinclair requested a review from akc2267 April 30, 2026 08:43

DanielSinclair force-pushed the daniel/discover-v2-market-carousels branch from 91c9a66 to b5f5ba8 Compare April 30, 2026 08:51

DanielSinclair force-pushed the daniel/placements-api branch from 4eb7984 to 3d587fb Compare April 30, 2026 08:51

This was referenced Apr 30, 2026

chore(discover): hide Farcaster tab from Trending #7414

Merged

feat(config): migrate experimental flags to Zustand store #7415

Open

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

DanielSinclair added 4 commits April 30, 2026 07:42

chore(discover-v2): remove deprecated feature cards

7e2d2bd

Clears out the old Perps/Predictions feature card surfaces before the new placement carousels are introduced.

refactor(discover-v2): move DiscoverHome to feature module

e4b2145

Pure path migration — isolated so reviewers see only the move.

feat(discover-v2): add MarketCarousel

bd56e19

Generic horizontal carousel component with shimmer skeleton loading, See All button, analytics trackPress slot, and variable-width item support. Used by both Perps and Predictions placements.

DanielSinclair force-pushed the daniel/discover-v2-market-carousels branch from b5f5ba8 to 6bbfc95 Compare April 30, 2026 11:42

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

DanielSinclair requested review from maxbbb and removed request for akc2267 April 30, 2026 23:23

ibrahimtaveras00 approved these changes May 1, 2026

View reviewed changes

maxbbb requested changes May 4, 2026

View reviewed changes


		export const HORIZONTAL_PADDING = 20;

		const keyExtractor = (item: PlacementItem) => `${item.ref.source}:${item.ref.id}`;

Conversation

DanielSinclair commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Screen recordings / screenshots

What to test

Uh oh!

DanielSinclair commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DanielSinclair commented Apr 30, 2026 •

edited

Loading

DanielSinclair commented Apr 30, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading