Skip to content

audit critical metric (blocking: 'zero') ignores the baseline value #13

Description

@rafaelvieiras

Problem

audit_critical uses blocking: 'zero', which fails whenever the current count is > 0, regardless of the baseline. There is no way to encode a known/accepted critical vulnerability — the gate hard-blocks even when there is no regression relative to the baseline.

Location

scripts/quality-gate.mjs / src/generators/gate-script.mjs (METRIC_DEFS + the blocking === 'zero' branch in compareMetrics)

Suggested fix

Optionally allow a ratchet-against-baseline mode for audit (fail only on increase vs baseline), or a documented allowlist, while keeping zero-tolerance as the default.

Acceptance

  • Projects with an accepted baseline critical can ratchet without permanently red CI; default stays zero-tolerance.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions