Problem
In fmtDelta, both branches of the arrow ternary are identical, so the lowerIsBetter parameter has no effect — the arrow reflects the numeric direction of change, not whether it is good or bad.
const arrow = lowerIsBetter
? (delta > 0 ? '↑' : '↓')
: (delta > 0 ? '↑' : '↓');
Location
scripts/quality-gate.mjs:318-320 and the same block in src/generators/gate-script.mjs
Suggested fix
Either make the arrow indicate good/bad using lowerIsBetter, or drop the unused parameter. Remember to regenerate scripts/quality-gate.mjs from the generator.
Acceptance
- No dead parameter; behavior intentional and tested.
Problem
In
fmtDelta, both branches of the arrow ternary are identical, so thelowerIsBetterparameter has no effect — the arrow reflects the numeric direction of change, not whether it is good or bad.Location
scripts/quality-gate.mjs:318-320and the same block insrc/generators/gate-script.mjsSuggested fix
Either make the arrow indicate good/bad using
lowerIsBetter, or drop the unused parameter. Remember to regeneratescripts/quality-gate.mjsfrom the generator.Acceptance