fix: Use correct paths for Secure Boot OVMF_VARS on NixOS hosts#1877
Closed
alexhaydock wants to merge 0 commit intoquickemu-project:masterfrom
Closed
fix: Use correct paths for Secure Boot OVMF_VARS on NixOS hosts#1877alexhaydock wants to merge 0 commit intoquickemu-project:masterfrom
alexhaydock wants to merge 0 commit intoquickemu-project:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: This is a trivial path correction in the Nix packaging configuration to fix Secure Boot functionality on NixOS. It is extremely isolated and low-risk.
a8f8a40 to
67a6d0d
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an extremely minor change that corrects the paths used for Secure Boot OVMF vars on NixOS.
This makes the assumption that by enabling
secureboot="on", the user wants their VARS store to be pre-populated with Microsoft's signing keys. I think this is a safe assumption and matches what we're doing for other host distributions.While this is not strictly a breaking change, it's worth noting that using a blank VARS store (as has been the case on NixOS until now) means Secure Boot remains in Setup (i.e. non-enforcing) mode. This means that Secure Boot has been non-functional for NixOS users until now, even when
secureboot="on"has been set. So there's a small chance that some users might see a change in behaviour here - though admittedly it'd only be when creating new VMs, as we don't overwrite the VARS store at any point for existing VMs.FWIW I also think the above population will be very small as Secure Boot was completely broken until 6d5b923 which didn't land until 4.9.8, and NixOS 25.11 is still shipping 4.9.7.
Type of change
Checklist: