fix: resolve all failing tests and type errors#66
Open
stooit wants to merge 1 commit into
Open
Conversation
…ages - auth middleware: fix case-sensitivity bug (lowercase 'post' never matched Hono's uppercase RFC 7231 method string, so POST /users wrongly required auth) - users route: import missing badRequest helper (ReferenceError on invalid body) - shared types: align field name userName -> username with API usage - pagination: implement the stubbed paginate() to satisfy the test contract - tsconfig: add bun-types so tsc resolves bun:test globals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and type errors across the
apiandsharedpackages. After these changesbun testreports 22 pass / 0 fail andbunx tsc --noEmitis clean.Bugs fixed
packages/api/src/middleware/auth.ts) — the public-methods list used lowercase'post', but Hono'sc.req.methodreturns the uppercase RFC 7231 string.POST /userswas therefore never treated as public and wrongly required a Bearer token. Changed'post'to'POST'.packages/api/src/routes/users.ts) — the invalid-body path calledbadRequest()which was never imported, a guaranteed runtimeReferenceError. Added it to the existing../lib/errorsimport.packages/shared/src/types.ts) — renameduserNametousernameto match how the API route references the field. No dangling references remain.packages/shared/src/utils/pagination.ts) — replaced the throwing stub with a real implementation (page slice, total/totalPages viaMath.ceil, correct empty/out-of-range handling) matching thePaginatedResponse<T>contract exercised by the tests.tsconfig.json) — added"types": ["bun-types"]sotscresolves thebun:testglobals used in test files.Verification
bun test-> 22 pass, 0 failbunx tsc --noEmit-> cleanConstraints honoured
Assumptions
bun-typeswas added totsconfig.jsontypesas the intended fix for thebun:testglobal type errors, since it is already a declared devDependency.