fix: repair failing tests and type errors across api + shared packages#63
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api + shared packages#63stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…d names, add missing import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and TypeScript errors.
bun test-> 22/22 pass;bunx tsc --noEmit-> 0 errors.Changes
packages/shared/src/utils/pagination.ts— Implemented thepaginate<T>()stub (was throwingnot implemented). Computestotal/totalPages(0 for empty input), slices via(page-1)*size, returnsdata,page,pageSize,total,totalPages. Handles out-of-range pages (empty data) and empty arrays.packages/api/src/middleware/auth.ts— Fixed a case-sensitivity bug in the public-route check soPOST /usersis correctly treated as public regardless of HTTP method casing. Resolved theCannot find name 'process'type error.packages/shared/src/types.ts— Aligned theUserfield name with the contract the tests expect, removing the cross-package inconsistency.packages/api/src/routes/users.ts— Added the missingbadRequestimport that caused a runtime/type failure.tsconfig.json— Adjusted types/lib config to resolve a type error without adding any dependency.Constraints honoured
Verification
bun test-> 22 pass, 0 failbunx tsc --noEmit-> exit 0