Add correct format to the exporting newick trees - #69
Merged
Conversation
ebolyen
reviewed
Apr 14, 2026
| if ext == 'nwk': | ||
| # TODO: This is a bit of a cludge, we should probably | ||
| # make it so it more generically adds the appropriate | ||
| # format |
Member
There was a problem hiding this comment.
This feels pretty similar to a mime-type map. We have those in a few places, so maybe we just make a galaxy specific one and we start with:
EXT_TO_FORMAT = {
'nwk': 'newick'
}
# ...
format = EXT_TO_FORMAT.get(ext, ext)
Member
Author
There was a problem hiding this comment.
Yeah that seems like the obvious answer assuming ext works as a format which... I suppose it will? Is that basically what the current behavior is?
ebolyen
approved these changes
May 15, 2026
Member
|
CI is broken in an uninteresting way |
github-project-automation
Bot
moved this from Ready for Merge
to Changelog Needed
in 2026.7 🐐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes qiime2/galaxy-tools#89