Add gss_localname and friends#374
Conversation
* gss_authorize_localname * gss_localname * gss_pname_to_uid * gss_userok Fixes pythongssapi#49 Signed-off-by: Jacob Henner <code@ventricle.us>
JacobHenner
force-pushed
the
feat/gss_localname-and-friends
branch
from
82c3132 to
39b3677
Compare
| @@ -0,0 +1,93 @@ | |||
| import typing as t | |||
|
|
|||
| if t.TYPE_CHECKING: | |||
There was a problem hiding this comment.
Do we need this check, I don't think the names and oids files will need to import this ext file and we shouldn't need to use the t.TYPE_CHECKING conditional import.
There was a problem hiding this comment.
I was following the pattern I observed in the other ext_*.pyi files within the same directory, but perhaps I've overlooked some other aspect that establishes the necessity for this block. What's the criteria for including/not including?
There was a problem hiding this comment.
I'm fairly certain it's only there when there are circular imports, e.g. names or oids import this file. The __init__.py is somewhat different enough that maybe it is required here but I wouldn't have thought so.
| if isinstance(username, str): | ||
| username = username.encode(_utils._get_encoding()) |
There was a problem hiding this comment.
Is there a benefit to accepting both bytes and str here? I would have thought we would just use bytes but it's been a while since I've looked at what some of the other functions are doing.
Not available on Windows. Include it conditionally to prevent build errors on Windows. Signed-off-by: Jacob Henner <code@ventricle.us>
2 participants
Fixes #49