Fix inferred type of a tuple indexed by a slice value#21721
Open
apoorva-01 wants to merge 1 commit into
Open
Conversation
The subscript path only treated literal slice syntax as a slice, so `t[s]` with `s: slice` fell through to the int-index result instead of tuple[...]. Fixes python#21708.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21708
(1, 2, 3)[s]withs: slicecame out asint, but it's a tuple at runtime anda.__getitem__(s)already getstuple[int, ...]right. The subscript code only spotted a slice written ast[1:2](aSliceExpr); aslicevariable is a plainNameExpr, so it fell through to the int-index branch. Now it checks the index type too.Test added next to
testNonliteralTupleSlice, fails on the old code. Left theint | sliceunion case alone, it still gives the item type.