gh-150368: Change Windows user group to secure identifier#150369
gh-150368: Change Windows user group to secure identifier#150369anytokin wants to merge 1 commit into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
vstinner
left a comment
There was a problem hiding this comment.
LGTM. But it would be nice if I could reproduce the issue to check the PR: #150368 (comment).
| probe = os.path.join(tempfile.tempdir, 'probe') | ||
| if os.name == 'nt': | ||
| cmd = ['icacls', tempfile.tempdir, '/deny', 'Everyone:(W)'] | ||
| #Use security identifier *S-1-1-0 instead |
There was a problem hiding this comment.
| #Use security identifier *S-1-1-0 instead | |
| # Use security identifier *S-1-1-0 instead |
|
Lib/test/test_ntpath.py and Lib/test/test_os/test_os.py already call |
|
LGTM with Victor's proposed comment fix. Not totally sure how far this should be backported, but easy enough to let the bot try and fail. |
Simmilar to 897bba7