Skip to content

fix datapath bart data#3425

Merged
fritzo merged 3 commits intopyro-ppl:devfrom
juanitorduz:fix_data_path_bart_data
Mar 12, 2025
Merged

fix datapath bart data#3425
fritzo merged 3 commits intopyro-ppl:devfrom
juanitorduz:fix_data_path_bart_data

Conversation

@juanitorduz
Copy link
Copy Markdown
Contributor

I was trying to simply run

from pyro.contrib.examples.bart import load_bart_od

dataset = load_bart_od()

and I was getting a timeout error. I saw this in NumPyro and this was fixed in pyro-ppl/numpyro#1996 by @fehiepsi . I tested the change locally (same strategy) and works as expected 🙏 .

@fritzo
Copy link
Copy Markdown
Member

fritzo commented Mar 11, 2025

Thanks for the fix! LGTM except you'll need to make lint or black or something. Looks like your editor accidentally reformatted some lines to exceed this codebase's max line length.

@fritzo fritzo added the bug label Mar 11, 2025
@juanitorduz
Copy link
Copy Markdown
Contributor Author

juanitorduz commented Mar 11, 2025

Fixed in e385602 (and ba6b5b0) :)

@fritzo fritzo enabled auto-merge (squash) March 12, 2025 19:43
@fritzo fritzo merged commit 6b5173c into pyro-ppl:dev Mar 12, 2025
3 checks passed
@juanitorduz juanitorduz deleted the fix_data_path_bart_data branch March 12, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants