Fix TraceEnum_ELBO ignoring is_auxiliary option#2164
Merged
fehiepsi merged 1 commit intopyro-ppl:masterfrom Mar 30, 2026
Merged
Fix TraceEnum_ELBO ignoring is_auxiliary option#2164fehiepsi merged 1 commit intopyro-ppl:masterfrom
fehiepsi merged 1 commit intopyro-ppl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2013
Summary
TraceEnum_ELBOcrashed with aKeyErrorwhen the guide contained sample sites marked withinfer={"is_auxiliary": True}that had no corresponding site in the model. This is a common pattern for constructing flexible variational families (e.g., sampling from a multivariate normal auxiliary and feeding it through Delta distributions).Root Cause
In
get_importance_trace_enum(numpyro/infer/elbo.py), when processing guide sites, the code unconditionally accessedmodel_trace[name]without first checking whether the site exists in the model trace: