Mark xfail for leaked tracer tests#1997
Merged
fehiepsi merged 8 commits intopyro-ppl:masterfrom Mar 7, 2025
Merged
Conversation
Member
Author
|
It seems that some issues were fixed so I'll just include the non-passing tests in the PR. |
Collaborator
|
Looks great! Worth considering a custom marker for this or too much? # conftest.py
def pytest_runtest_setup(item):
marker = item.get_closest_marker("xfail_tracer_leak")
if marker is not None and os.environ.get("JAX_CHECK_TRACER_LEAKS") == "1":
item.add_marker(pytest.mark.xfail(reason="Expected tracer leak."))
# test files
@pytest.mark.xfail_tracer_leak
def test_...():
... |
Member
Author
|
Thanks for the suggestion! I prefer using pytest.mark it directly. There are only 4 issues left (yay!), which I have created separate github issues for each of them.
While debugging, I found that there are many live arrays over the tests so I take this chance to remove all of them (and add a small check to conftest to assure that no live arrays will be created globally). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an entry in github action to track leaked tracer failing tests reported in #1981. I found the behaviors under JAX_CHECK_TRACER_LEAKS is a bit different from the normal behaviors so just want to perform a subset of tests.
Fixes #1981