fix: doit forget crashes with TypeError when no default tasks specified#484
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: doit forget crashes with TypeError when no default tasks specified#484AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
When no default_tasks are configured, doit forget throws TypeError: 'NoneType' object is not iterable because sel_tasks is None. Now treats None as 'all tasks', consistent with how doit run behaves when no tasks are specified. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doit forget throws TypeError: 'NoneType' object is not iterable when no default_tasks are configured in dodo.py. The _execute method tries to iterate over self.sel_tasks which is None when no default tasks exist.
Now treats None sel_tasks as 'all tasks' — consistent with how doit run works when no tasks are specified. A 2-line fix in cmd_forget.py.