preparations for musllinux#367
Merged
reaperhulk merged 2 commits intopyca:mainfrom Sep 18, 2021
liath:musllinux
Merged
Conversation
4 tasks
reaperhulk
reviewed
Aug 29, 2021
reaperhulk
reviewed
Aug 29, 2021
Member
|
CI won’t pass until that docker image tag exists, but modulo my comments this generally looks fine. I look forward to seeing all of this land! |
Contributor
Author
|
Yay! I added the exclude block you mentioned to the cryptography PR too. :) |
reaperhulk
approved these changes
Sep 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should get everything going once musllinux is available from pypa/manylinux#1135
I should caveat this PR by saying that afaik this is my first day touching anything in the python ecosystem so apologies if this is dumb lol
Also I kinda anticipate the pypy shuffling in cryptography-manylinux/Dockerfile-manylinux will not pass review but I included it in the off chance no one cares (why is pypy used in the pyca/cryptography builds?) or if any one wants to test building Alpine cryptography wheels with musllinux. Here's how I did that: