-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ENH: Extract the /FontFile and store it in the new FontDescriptor class #3602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
michelcrypt4d4mus
wants to merge
15
commits into
py-pdf:main
from
michelcrypt4d4mus:font_description_font_file
+56
−4
Closed
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b32ee5f
Extract the /FontFile and store it in the new FileDescriptor object
88af6c6
alphabetize imports
4416a36
use Union for python 3.9
4a41aa5
cast types
7783907
address comments, fix test
e9a7d2d
add tests for /FontFile, /FontFile2, /FontFile3
4f087af
Fix failing test
17a7bc7
Fix failing test
c2c61c7
fix ruff test
a743058
fix style
73a7b43
unused import
acc25ce
remove unnecessary @pytest.mark.enable_socket (all test files are local
ddd41be
unused import
89397d6
test coverage for error case
9804af2
ruff
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.