Skip to content

[codex] raise upload limit and inline safe code reloader#3

Merged
puppe1990 merged 2 commits into
mainfrom
codex/upload-limit-and-code-reloader
May 11, 2026
Merged

[codex] raise upload limit and inline safe code reloader#3
puppe1990 merged 2 commits into
mainfrom
codex/upload-limit-and-code-reloader

Conversation

@puppe1990
Copy link
Copy Markdown
Owner

What changed

This PR contains two isolated commits:

  1. Raise the direct upload file size limit from 2 GB to 5 GB, and update the frontend/controller/gettext messaging to reflect the configured limit.
  2. Inline the safe code reloader behavior into OpenDriveWeb.Endpoint, removing the dedicated wrapper module and keeping the existing guard/test coverage.

Why

Large uploads were being rejected by the direct upload preparation step once the selected file exceeded 2_000_000_000 bytes. In practice that can also affect files that appear as roughly 1.9 GB in the UI because the browser display rounds values while the server validates exact bytes.

The code reloader change reduces indirection by keeping endpoint-specific plug behavior in the endpoint module itself.

Impact

Users can now upload files up to 5 GB through the direct upload flow.
The upload error messaging now reflects the effective configured limit instead of a hardcoded 2 GB string.
The development endpoint keeps the same guarded code reload behavior with one less module to maintain.

Validation

  • mix test test/open_drive/drive_test.exs test/open_drive_web/controllers/direct_upload_controller_test.exs test/open_drive_web/safe_code_reloader_test.exs

@puppe1990 puppe1990 marked this pull request as ready for review May 11, 2026 15:51
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@puppe1990 puppe1990 merged commit e965700 into main May 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant