[codex] raise upload limit and inline safe code reloader#3
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR contains two isolated commits:
OpenDriveWeb.Endpoint, removing the dedicated wrapper module and keeping the existing guard/test coverage.Why
Large uploads were being rejected by the direct upload preparation step once the selected file exceeded
2_000_000_000bytes. In practice that can also affect files that appear as roughly 1.9 GB in the UI because the browser display rounds values while the server validates exact bytes.The code reloader change reduces indirection by keeping endpoint-specific plug behavior in the endpoint module itself.
Impact
Users can now upload files up to 5 GB through the direct upload flow.
The upload error messaging now reflects the effective configured limit instead of a hardcoded 2 GB string.
The development endpoint keeps the same guarded code reload behavior with one less module to maintain.
Validation
mix test test/open_drive/drive_test.exs test/open_drive_web/controllers/direct_upload_controller_test.exs test/open_drive_web/safe_code_reloader_test.exs