Assign precise train types to NL OVapi trains#2061
Open
dancojocaru2000 wants to merge 1 commit intopublic-transport:mainfrom
Open
Assign precise train types to NL OVapi trains#2061dancojocaru2000 wants to merge 1 commit intopublic-transport:mainfrom
dancojocaru2000 wants to merge 1 commit intopublic-transport:mainfrom
Conversation
Contributor
|
LGTM. I guess you already tried this locally with MOTIS to check if it works? |
Contributor
Author
|
I haven't, I haven't found instructions on how to run the script locally so I just based my edits on other scripts already in the repo, mainly the |
Contributor
|
It should be easy to do like this (download the motis binary, run I'm not sure how we can otherwise check scripts before merge. |
Member
|
See also #1864. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.