ci: pin go-version to 1.23 matching go.mod#34
Merged
Conversation
dpop-cross-language-tests/go-test/go.mod already declares `go 1.23`, but ci.yml's setup-go step pinned go-version: '1.21'. Under setup-go v5 this worked because v5 lazily downloaded the matching toolchain at build time. setup-go v6 tightens toolchain handling and refuses to silently bridge the mismatch. Bumping the pin to '1.23' aligns the workflow with the module directive and unblocks the actions-all dep group bump (PR #30) that otherwise breaks the DPoP Cross-Language Interop test. Signed-off-by: unix-oidc Developers <prodnull@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`dpop-cross-language-tests/go-test/go.mod` declares `go 1.23` but `ci.yml` pins `go-version: '1.21'` for the DPoP Cross-Language Interop test. Under `actions/setup-go@v5` this silently worked: v5 lazily downloaded the matching toolchain at build time. `actions/setup-go@v6` tightens toolchain handling and refuses the mismatch, so the test now fails with "Failed to build Go test" (the script swallows the actual go build error via `2>/dev/null`).
Fix
Pin `go-version: '1.23'` to match `go.mod`. One-line change.
Why this matters now
PR #30 (the `actions-all` group bump) raises setup-go to v6, which is what surfaces the latent inconsistency. Landing this fix first lets dependabot rebase #30 cleanly.
Test plan