Skip to content

fix(ci): upgrade eslint to v10 by removing incompatible eslint-plugin-github#345

Draft
Copilot wants to merge 3 commits intomainfrom
copilot/sub-pr-339
Draft

fix(ci): upgrade eslint to v10 by removing incompatible eslint-plugin-github#345
Copilot wants to merge 3 commits intomainfrom
copilot/sub-pr-339

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

eslint-plugin-github@6.0.0 declares eslint@^8 || ^9 as a peer dependency, blocking npm ci entirely after the eslint v10 bump.

Changes

  • Remove eslint-plugin-github — all its rules (github/*, eslint-comments/*, filenames/*, import/*, i18n-text/*) were already explicitly disabled in the flat config, making the dependency a no-op
  • Add @eslint/js as an explicit devDependency — required for eslint v10 flat config (js.configs.recommended)
  • Clean up eslint.config.js — remove the plugin import, its registration in plugins, and all now-orphaned rule overrides
  • Fix no-useless-assignment in global-announce.ts — new rule enforced by eslint v10; resolved by merging the redundant initializer into the first real assignment:
    // before
    let liveRegion: LiveRegionElement | null = null
    liveRegion = from ? getClosestLiveRegion(from) : null
    
    // after
    let liveRegion: LiveRegionElement | null = from ? getClosestLiveRegion(from) : null

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

dependabot bot and others added 2 commits March 9, 2026 22:03
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.2 to 10.0.3.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v9.39.2...v10.0.3)

---
updated-dependencies:
- dependency-name: eslint
  dependency-version: 10.0.3
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 9, 2026

⚠️ No Changeset found

Latest commit: 0ab800f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…slint/js dep

Co-authored-by: liuliu-dev <6688812+liuliu-dev@users.noreply.github.com>
Copilot AI changed the title [WIP] Bump eslint from 9.39.2 to 10.0.3 fix(ci): upgrade eslint to v10 by removing incompatible eslint-plugin-github Mar 9, 2026
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/eslint-10.0.3 branch from 637e20c to 58da3ef Compare March 9, 2026 22:56
Base automatically changed from dependabot/npm_and_yarn/eslint-10.0.3 to main March 9, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants