Skip to content

Support cmake-js#75

Open
thegecko wants to merge 1 commit into
prebuild:masterfrom
thegecko:cmake-js
Open

Support cmake-js#75
thegecko wants to merge 1 commit into
prebuild:masterfrom
thegecko:cmake-js

Conversation

@thegecko

@thegecko thegecko commented Dec 3, 2023

Copy link
Copy Markdown

Fixes #49

This PR adds support for driving cmake-js in the same way as prebuild by using the --backend flag. e.g.:

prebuildify --backend cmake-js -- --prefer-clang

@vweevers

vweevers commented Dec 3, 2023

Copy link
Copy Markdown
Member

I prefer the generic approach of #7.

@thegecko

thegecko commented Dec 3, 2023

Copy link
Copy Markdown
Author

I prefer the generic approach of #7.

AFAICT that removes all build support and instead the user needs to define their own external script command?

That approach is quite a breaking change as all users of prebuildify would need to all specify (the same) replacement build script externally. This feels opaque and not very user friendly.

If there were a lot of common build backends, I can see the benefit of that approach, but I'm not aware of anything outside of just node-gyp and cmake-js.

Another benefit of this approach is it aligns with the existing prebuild package.

@vaguue

vaguue commented Jul 12, 2024

Copy link
Copy Markdown

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cmake-js support

3 participants