New Adapter: Synapse HX by prebid-compas · Pull Request #4795 · prebid/prebid-server

prebid-compas · 2026-05-26T13:34:38Z

Docs PR - prebid/prebid.github.io#6581

Related Changes

New Adapter: Synapse HX prebid-server-java#4532

github-actions · 2026-06-02T14:21:40Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 0a22422

synapseHX

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:28:	MakeRequests		82.4%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:66:	MakeBids		94.7%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:106:	buildRequestHeaders	100.0%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:115:	getMediaTypeForBid	76.9%
total:									(statements)		87.5%

bsardo · 2026-06-02T20:30:45Z

@@ -0,0 +1,21 @@
+endpoint: "https://rtb.hx.compasonline.com/pbs"


Verified the endpoint is live

curl -i --location --request POST "https://rtb.hx.compasonline.com/pbs" HTTP/1.1 400 Bad Request Content-Length: 0 Date: Tue, 02 Jun 2026 20:30:19 GMT Server: Kestrel

bsardo · 2026-06-02T20:33:04Z

@@ -0,0 +1,21 @@
+endpoint: "https://rtb.hx.compasonline.com/pbs"
+maintainer:
+  email: prebid@compas-inc.com


We've sent an email to this address. Please respond to the email to verify that it is reachable.

Verified receipt.

bsardo · 2026-06-02T20:37:40Z

+  redirect:
+    url: "https://sync.hx.compasonline.com/pbserver/image?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&ccpa={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&redirect={{.RedirectURL}}"
+    userMacro: "${VISITOR_ID}"


Is this endpoint live? I sent the following request which hangs:
https://sync.hx.compasonline.com/pbserver/image?gdpr=0&gdpr_consent=&ccpa=&gpp=&gpp_sid=&redirect=http%3A%2F%2Flocalhost%3A8000%2Fsetuid%3Fbidder%3DsynapseHX%26gdpr%3D0%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Di%26uid%3D%24%7BVISITOR_ID%7D

Thank you. Endpoint has been fixed.

bsardo · 2026-06-02T20:37:49Z

+    url: "https://sync.hx.compasonline.com/pbserver/image?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&ccpa={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&redirect={{.RedirectURL}}"
+    userMacro: "${VISITOR_ID}"
+  iframe:
+    url: "https://sync.hx.compasonline.com/pbserver/iframe?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&ccpa={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&redirect={{.RedirectURL}}"


Is this endpoint live? I sent the following request which hangs:
https://sync.hx.compasonline.com/pbserver/iframe?gdpr=0&gdpr_consent=&ccpa=&gpp=&gpp_sid=&redirect=http%3A%2F%2Flocalhost%3A8000%2Fsetuid%3Fbidder%3DsynapseHX%26gdpr%3D0%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%24%7BVISITOR_ID%7D

Thank you. Endpoint has been fixed.

bsardo · 2026-06-02T20:40:07Z

+		case openrtb2.MarkupVideo:
+			return openrtb_ext.BidTypeVideo, nil
+		default:
+			return "", fmt.Errorf("unsupported media type %d", bid.MType)
+		}


Please add supplemental JSON tests to cover these cases.

bsardo · 2026-06-02T21:13:14Z

+		if err := jsonutil.Unmarshal(request.Imp[0].Ext, &bidderExt); err != nil {
+			errors = append(errors, fmt.Errorf("failed to unmarshal bidder ext: %w", err))
+		}
+
+		var ext openrtb_ext.ExtImpSynapseHX
+		if err := json.Unmarshal(bidderExt.Bidder, &ext); err != nil {
+			errors = append(errors, fmt.Errorf("failed to unmarshal bidder parameters: %w", err))
+		}


If you're unable to successfully unmarshal the bidder params, you won't have the tenant ID. In that case, I think you want to early return with nil, errors instead of hitting the bidder endpoint with no tenant ID. Thoughts?

bsardo · 2026-06-02T21:13:49Z

+
+	requestBody, err := jsonutil.Marshal(request)
+	if err != nil {
+		errors = append(errors, fmt.Errorf("failed to marshal request: %w", err))


Same thing here, early return nil, errors?

bsardo · 2026-06-02T21:22:57Z

+	}
+
+	var errs []error
+	bidderResponse := adapters.NewBidderResponseWithBidsCapacity(len(bidResponse.SeatBid[0].Bid))


I suggest ensuring there is at least one seatbid before attempting to access the first element.
Something like:

if len(bidResponse.SeatBid) == 0 { return nil, nil }

or

if len(bidResponse.SeatBid) == 0 { return nil, []error{&errortypes.BadServerResponse{ Message: "Empty SeatBid array", }} }

depending on what makes sense for you.

bsardo · 2026-06-02T21:26:13Z

+	if len(bidResponse.SeatBid) == 0 || len(bidResponse.SeatBid[0].Bid) == 0 {
+		return nil, nil
+	}


I think this can be deleted. I suggested a check above to ensure there is a seat bid before sizing the bidder response.

If the server returns a valid 200 response with an empty seatbid array, this panics at runtime. The empty-check must come before SeatBid[0] is indexed. This is likely the same issue flagged by reviewer @bsardo.

bsardo · 2026-06-02T21:27:02Z

+	}
+
+	var errs []error
+	bidderResponse := adapters.NewBidderResponseWithBidsCapacity(len(bidResponse.SeatBid[0].Bid))


Please also cover the new logic I suggested above with a supplemental JSON test.

przemkaczmarek · 2026-06-03T04:54:45Z

+
+	if len(request.Imp) > 0 {
+		var bidderExt adapters.ExtImpBidder
+		if err := jsonutil.Unmarshal(request.Imp[0].Ext, &bidderExt); err != nil {


A failed first unmarshal leaves bidderExt.Bidder as nil, then the second unmarshal proceeds on bad state. Both unmarshal errors should return early.

przemkaczmarek · 2026-06-03T04:55:21Z

+		}
+
+		var ext openrtb_ext.ExtImpSynapseHX
+		if err := json.Unmarshal(bidderExt.Bidder, &ext); err != nil {


Should consistently use jsonutil.Unmarshal throughout.

przemkaczmarek · 2026-06-03T04:56:22Z

+
+type ExtImpSynapseHX struct {
+	TenantID string `json:"tenantId"`
+	AdUnitID string `json:"adUnitId,omitempty"`


ExtImpSynapseHX.AdUnitID is defined and present in the JSON schema (adUnitId), but the adapter never reads or forwards it. Either use it or remove it. Leaving it creates false expectations for publishers.

przemkaczmarek · 2026-06-03T04:57:25Z

+	if buildErr != nil {
+		t.Fatalf("Builder returned unexpected error %v", buildErr)
+	}
+	adapterstest.RunJSONBidderTest(t, "synapseHXtest", bidder)


The convention in this repo is to pass the adapter directory name (e.g., "synapseHX"), not "synapseHXtest". This may cause the test to silently look in the wrong directory.

Thank you.

We checked this across the repository and based on the existing usage examples it does not match with your suggestion - here are a few screenshots from the repo for reference. The same behavior also seems to be aligned with the official documentation here: https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#test-your-adapter

Please, let us know your opinion. On our side, we have ready-to-push change to address this.

przemkaczmarek · 2026-06-03T04:58:20Z

+	"github.com/prebid/prebid-server/v4/openrtb_ext"
+)
+
+func TestValidParams(t *testing.T) {


As flagged by @bsardo, tests are missing for:

Empty seatbid array in response

request.Imp is empty

Unmarshal failure on impression ext

getMediaTypeForBid with no mtype and no bid.ext

The reported 76.9% coverage on getMediaTypeForBid confirms these gaps.

Tests were added.

github-actions · 2026-06-08T09:18:13Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2033b28

synapseHX

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:28:	MakeRequests		95.2%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:72:	MakeBids		100.0%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:112:	buildRequestHeaders	100.0%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:121:	getMediaTypeForBid	92.3%
total:									(statements)		96.7%

github-actions · 2026-06-09T12:49:07Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f70eabf

synapseHX

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:28:	MakeRequests		95.2%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:72:	MakeBids		100.0%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:112:	buildRequestHeaders	100.0%
github.com/prebid/prebid-server/v4/adapters/synapseHX/synapseHX.go:121:	getMediaTypeForBid	92.3%
total:									(statements)		96.7%

Implementation of the Synapse HX adapter

0d9643b

prebid-compas mentioned this pull request May 26, 2026

New Adapter: Synapse HX prebid/prebid.github.io#6581

Merged

7 tasks

prebid-compas marked this pull request as ready for review May 26, 2026 17:02

Merge branch 'master' into implement-synapsehx-adapter

0a22422

bsardo assigned przemkaczmarek and bsardo Jun 2, 2026

bsardo reviewed Jun 2, 2026

View reviewed changes

przemkaczmarek reviewed Jun 3, 2026

View reviewed changes

prebid-compas added 2 commits June 8, 2026 10:37

Adjustments according to the review

48994af

Merge branch 'master' into implement-synapsehx-adapter

2033b28

prebid-compas mentioned this pull request Jun 8, 2026

New Adapter: Synapse HX prebid/prebid-server-java#4532

Open

21 tasks

przemkaczmarek approved these changes Jun 8, 2026

View reviewed changes

Merge branch 'master' into implement-synapsehx-adapter

f70eabf

bsardo added the adapter label Jun 9, 2026

bsardo approved these changes Jun 9, 2026

View reviewed changes

bsardo merged commit f5f6439 into prebid:master Jun 9, 2026
6 checks passed

cross-repo-issue-creation Bot mentioned this pull request Jun 9, 2026

Port PR from PBS-Go: New Adapter: Synapse HX prebid/prebid-server-java#4544

Open

		@@ -0,0 +1,21 @@
		endpoint: "https://rtb.hx.compasonline.com/pbs"

Uh oh!

Conversation

prebid-compas commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Changes

Uh oh!

github-actions Bot commented Jun 2, 2026

Code coverage summary

synapseHX

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 8, 2026

Code coverage summary

synapseHX

Uh oh!

github-actions Bot commented Jun 9, 2026

Code coverage summary

prebid-compas commented May 26, 2026 •

edited

Loading