Addigi: New alias for Smarthub

[katherynhrabik]

🔧 Type of changes

• new bid adapter
• bid adapter update
• new feature
• new analytics adapter
• new module
• module update
• bugfix
• documentation
• configuration
• dependency update
• tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?
Addigi alias added to SmartHub (Attekmi)

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?
N/A - just an alias

🔎 New Bid Adapter Checklist

• verify email contact works
• NO fully dynamic hostnames
• geographic host parameters are NOT required
• direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
• if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
• cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

• Are your changes following our code style guidelines?
• Are there any breaking changes in your code?
• Does your test coverage exceed 90%?
• Are there any erroneous console logs, debuggers or leftover code in your changes?

[AntoxaAntoxic]

Is it a port from Go? Or should it be ported to Go?

[katherynhrabik]

Is it a port from Go? Or should it be ported to Go?

it's a port from Go: #3750

[AntoxaAntoxic]

placeholders are unnecessary if they are not checked in the test

[katherynhrabik]

hi sorry if this is a silly question, does this not count as being checked in the test? post(urlPathEqualTo("/addigi-exchange"))

[AntoxaAntoxic]

it mocks all the requests going to the path /addigi-exchange neglecting query params

so from my perspective having query params in the http://localhost:8090/addigi-exchange?host={{Host}}&accountId={{AccountID}}&sourceId={{SourceId}} is kind of redundant, because it doesn't impact the test at all

therefore I can suggest using just the http://localhost:8090/addigi-exchange endpoint which is sufficient OR as an alternative you can add checks for query params in the test