Clamp slider velocity calculation for sliders overlapping other objects#38231
Open
stanriders wants to merge 3 commits into
Open
Clamp slider velocity calculation for sliders overlapping other objects#38231stanriders wants to merge 3 commits into
stanriders wants to merge 3 commits into
Conversation
Member
|
Is this intended to be deployed immediately? |
Member
Author
|
Up to you really, it's related to https://discord.com/channels/546120878908506119/1283498831224373278/1523592304286236692 |
tsunyoku
reviewed
Jul 8, 2026
tsunyoku
left a comment
tsunyoku
left a comment
Member
There was a problem hiding this comment.
Could we maybe handle this information in ODHO instead? Duplicating this in both places feels not great, and if we need to do this elsewhere suddenly then its yet another copy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to 2B sliders being longer than the delta time between slider and next object we end up having next object after the 2B slider start with velocity of
full slider distance / delta between slider and next objectwhich is usually insanely high.https://osu.ppy.sh/beatmapsets/497995#osu/1060000 26.688 -> 3.94*
https://osu.ppy.sh/beatmapsets/982020#osu/2055234 162.303 -> 48.32*
https://osu.ppy.sh/beatmapsets/756794#osu/1605148 7.441 -> 6.14*
https://osu.ppy.sh/beatmapsets/90935#osu/272317 5.895 -> 5.34*