Merged
Conversation
🦋 Changeset detectedLatest commit: 5bb7870 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
reviewed
Apr 13, 2026
Contributor
rkistner
left a comment
There was a problem hiding this comment.
I think it's great to track & report this, but should be clear on the wording.
Note that there are actually two separate limits, both with a default of 1000, and both reported with code PSYNC_S2305:
- "Too many buckets". This is what the PR here measures.
- "Too many parameter query results".
These are often the same, but is different in some important cases:
- If the parameter query or sync stream subquery has duplicate results, those are counted individually for "parameter query results", but de-duplicated in the bucket count.
- Queries that don't result in partitioning don't count towards "parameter query results", but do count 1 towards the number of buckets.
Another point is that the limit of 1000 is the default. While it's not common to change this, the text here shouldn't present that as always the case.
c59ba20 to
700175b
Compare
bean1352
reviewed
Apr 13, 2026
bean1352
previously approved these changes
Apr 13, 2026
benitav
reviewed
Apr 13, 2026
bean1352
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances the Sync Diagnostics page by making the server-side parameter query result limit more visible to users and providing clearer warnings as the bucket count approaches this limit.