Streamline dispatch of Assign operators#1348
Open
lionel- wants to merge 1 commit into
Open
Conversation
lionel-
force-pushed
the
oak-nse/10-assign-streamlining
branch
from
July 17, 2026 08:56
19f723f to
647cafb
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
July 17, 2026 08:56
bdc02fa to
96dff66
Compare
lionel-
force-pushed
the
oak-nse/10-assign-streamlining
branch
from
July 17, 2026 11:26
647cafb to
f2eeae6
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
July 17, 2026 11:26
96dff66 to
dacdce8
Compare
lionel-
force-pushed
the
oak-nse/9-unquote
branch
from
July 17, 2026 13:55
dacdce8 to
604935e
Compare
lionel-
force-pushed
the
oak-nse/10-assign-streamlining
branch
from
July 17, 2026 13:55
f2eeae6 to
4cf3864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #1338
Branched from #1347
Refactor, no behavior change. Assign effects come in two variants, a call (
assign("x", v)) and a binding operator (x %<>% f), and until now only the call went through a handler. The operator was hand-built in the builder, using the registry only to check a handler was present, and the operator registry entries carried a phantomposition: 0that was never read.The refactor moves the operator logic into the handler layer, symmetric with calls. Supporting infra: A new
EffectSite(Call|Operator) to disambiguate the variants, and a newAssignHandlertrait.