Fix send() return value checks in negotiation code paths#32
Merged
SeanTAllen merged 2 commits intomainfrom Feb 23, 2026
Merged
Conversation
The HELLO and AUTH sends during connection negotiation didn't check the send() return value. If send() returned an error, the negotiation command was silently lost and the session would hang forever waiting for a response that would never arrive. Reorder each site so the send() happens before the state transition. Only transition on successful send. On failure, shut down the session cleanly. Closes #30
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
SeanTAllen
removed
the
changelog - fixed
Project has not been released yet — no release notes needed.
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HELLO and AUTH sends during connection negotiation didn't check the send() return value. If send() returned an error, the negotiation command was silently lost and the session would hang forever waiting for a response that would never arrive.
Each site is reordered so send() happens before the state transition. Only transition on successful send. On failure, shut down the session cleanly.
Closes #30