Skip to content

Replace Nav, Position and VisibilityChecker with cs2-nav rust alternatives#382

Open
JanEricNitschke wants to merge 3 commits intopnxenopoulos:mainfrom
JanEricNitschke:switch-to-cs2-nav
Open

Replace Nav, Position and VisibilityChecker with cs2-nav rust alternatives#382
JanEricNitschke wants to merge 3 commits intopnxenopoulos:mainfrom
JanEricNitschke:switch-to-cs2-nav

Conversation

@JanEricNitschke
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

tests/test_visibility.py:32

  • Verify that the new ray_intersection method returns results consistent with the previous _ray_triangle_intersection implementation, particularly regarding the handling of intersection distances.
t = triangle.ray_intersection(start_vec, direction)

awpy/vector.py:7

  • [nitpick] Aliasing cs2_nav's Position class as Vector3 may be slightly misleading if Position has differing semantics compared to the original Vector3; consider adding a clarifying comment if needed.
from cs2_nav import Position as Vector3  # noqa: F401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants