Replace Nav, Position and VisibilityChecker with cs2-nav rust alternatives#382
Open
JanEricNitschke wants to merge 3 commits intopnxenopoulos:mainfrom
Open
Replace Nav, Position and VisibilityChecker with cs2-nav rust alternatives#382JanEricNitschke wants to merge 3 commits intopnxenopoulos:mainfrom
JanEricNitschke wants to merge 3 commits intopnxenopoulos:mainfrom
Conversation
4b2de88 to
c333f56
Compare
There was a problem hiding this comment.
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/test_visibility.py:32
- Verify that the new ray_intersection method returns results consistent with the previous _ray_triangle_intersection implementation, particularly regarding the handling of intersection distances.
t = triangle.ray_intersection(start_vec, direction)
awpy/vector.py:7
- [nitpick] Aliasing cs2_nav's Position class as Vector3 may be slightly misleading if Position has differing semantics compared to the original Vector3; consider adding a clarifying comment if needed.
from cs2_nav import Position as Vector3 # noqa: F401
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.