Make plot rounds respect levels#300
Open
JanEricNitschke wants to merge 3 commits intopnxenopoulos:mainfrom
Open
Make plot rounds respect levels#300JanEricNitschke wants to merge 3 commits intopnxenopoulos:mainfrom
JanEricNitschke wants to merge 3 commits intopnxenopoulos:mainfrom
Conversation
pnxenopoulos
previously approved these changes
Oct 21, 2023
Owner
pnxenopoulos
left a comment
pnxenopoulos
left a comment
There was a problem hiding this comment.
looks great. i think this addresses the question in Discord
Collaborator
Author
|
I would still like to figure out why the levels half the width instead of doubling the height. |
Owner
All good, in no rush to merge |
Collaborator
Author
|
Shoud be all good now. But note that there are breaking changes in here to plot_positions. |
Owner
|
Currently adding this in v2. Will be referencing. I found in the data the z-level cutoffs fortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously plot rounds showed the two levels for maps that have them but only plotted the player and bomb in the upper half. Now it should also plot them in the lower one if they are there.