fix(core): centralize time defaults#950
Conversation
PR Review: FAILWhat This DoesCentralizes reconnect/timestamp defaults across exchange WebSockets, normalizers, and SDK server-manager status conversion. This should be an internal cleanup with no intended SDK response-shape change. Blast RadiusCore WebSocket clients for Gemini Titan, Kalshi, Limitless, Opinion, Probable; Polymarket/Probable normalizers; Python and TypeScript server-manager status helpers. Consumer VerificationBefore (base branch): After (PR branch): Test Results
Findings
PMXT Pipeline Check
Semver Impactpatch -- intended internal cleanup, but currently unmergeable because it breaks the build. RiskNo runtime behavior could be verified because the TypeScript build fails. |
|
Pushed follow-up commits to repair the deterministic build blocker: removed the duplicate local |
PR Review: PASS (NOT VERIFIED)What This DoesCentralizes timestamp conversion and reconnect default constants, then applies them across several exchange websocket/normalizer/fetcher paths and SDK server-manager uptime parsing. This reduces duplicated epoch-second/ms heuristics and reconnect magic numbers. Blast RadiusCore websocket clients and timestamp normalizers for Gemini Titan, Kalshi, Limitless, Opinion, Polymarket, and Probable; Python and TypeScript server manager uptime parsing; generated API doc metadata timestamp only. Consumer VerificationBefore (base branch): After (PR branch): Test Results
FindingsNo blocking findings. PMXT Pipeline Check
Semver Impactpatch -- internal utility/refactor with unchanged public response shape. RiskThe Limitless websocket fallback reconnect delay changes from 1000ms to the shared 5000ms default; that seems intentional for consistency but was not validated against live feed recovery behavior. |
Summary
Fixes #206
Fixes #225
Test Plan