Topic/lukev/improvements#27
Open
upenn-cis551 wants to merge 3 commits intoplum-umd:masterfrom
Open
Conversation
Collaborator
upenn-cis551
commented
Feb 9, 2018
- Auto-create directories (BASE_PATH, ARCHIVE_PATH, BREAKS_PATH, etc.) in bibifi-periodic/periodic.py when they do not already exist. These directories should either be created automatically when they don't exist, or the periodic.py script should exit with a message that the directories don't exist.
- Catch TypeError bug. This came up when a student messed with their git history causing the periodic.py script to look for a non-existent treeish, which caused it to crash.
- Fix some comments: aws -> cloud
Member
|
Thanks @ltv511! I'm sort of leaning towards the case where we check ahead of time and exit when these directories don't exist. That way if the user accidentally provides the wrong options, they get an error rather than silently creating the directories where they don't expect. I can also imagine scenarios where data ends up split between multiple locations. Do you want to implement this? If not, could you add another commit that reverts |
Collaborator
|
Sure! I’m traveling with limited internet access for the next two weeks, but can implement this when I’m back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.