feat(SRE-8899): only support the new approach (migration 2/2)#23
Merged
feat(SRE-8899): only support the new approach (migration 2/2)#23
Conversation
There was a problem hiding this comment.
Pull request overview
This PR completes migration “2/2” by removing support for the legacy aws-secret volume approach and aligning local fixtures/runtime wiring with the new split between application-scoped and global (flux-config) config sources.
Changes:
- Removes legacy
test/fixture/volumes/aws-secret/*fixtures and removes several fixtures from the application-scopedaws-parameter-storefixture set that are now treated as global. - Updates
parse-config.shto document the 4-source layout and to stop loading$WORKDIR/aws-secret(legacy path), while continuing to load application and global sources. - Updates
docker-compose.ymlto stop mounting the legacy$WORKDIR/aws-secretfixture volume.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
parse-config.sh |
Drops loading of legacy $WORKDIR/aws-secret and updates inline documentation to reflect the 4 directories (app + global). |
docker-compose.yml |
Removes the legacy aws-secret fixture mount; keeps mounts for app-scoped and global volumes. |
test/fixture/volumes/aws-secret/with_special_chars |
Removes legacy secret fixture file (old approach). |
test/fixture/volumes/aws-secret/infrastructure_private.terraform |
Removes legacy secret fixture file (old approach). |
test/fixture/volumes/aws-secret/infrastructure_openai_key |
Removes legacy secret fixture file (old approach). |
test/fixture/volumes/aws-secret/infrastructure_launch-darkly_key |
Removes legacy secret fixture file (old approach). |
test/fixture/volumes/aws-secret/infrastructure_global_launch-darkly_key |
Removes legacy secret fixture file (old approach). |
test/fixture/volumes/aws-secret/ignore_multiline |
Removes legacy multiline fixture file (old approach). |
test/fixture/volumes/aws-parameter-store/_infrastructure_msk_endpoint |
Removes fixture from app-scoped parameter store set (now expected as global). |
test/fixture/volumes/aws-parameter-store/_application_kerberos_redis_kerberos-authz_url |
Removes fixture from app-scoped parameter store set (now expected as global). |
test/fixture/volumes/aws-parameter-store/_application_kerberos_authentication_allowed_issuers |
Removes fixture from app-scoped parameter store set (now expected as global). |
test/fixture/volumes/aws-parameter-store/_application_global_kerberos_cache_kerberos-authz_url |
Removes fixture from app-scoped parameter store set (now expected as global). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rbailly-pleo
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear Story
We are migrating global properties outside of application helm-chart.
This is the second iteration.
The desired status is this one:
<app>-aws-secret-application(application helm-chart)<app>-aws-parameter-store(application helm-chart)global-aws-secret(flux-config)global-aws-parameter-store(flux-config)