Skip to content

feat(SRE-8899): only support the new approach (migration 2/2)#23

Merged
vmarlier merged 3 commits intomainfrom
SRE-8899/second-iteration
Apr 8, 2026
Merged

feat(SRE-8899): only support the new approach (migration 2/2)#23
vmarlier merged 3 commits intomainfrom
SRE-8899/second-iteration

Conversation

@vmarlier
Copy link
Copy Markdown
Contributor

@vmarlier vmarlier commented Apr 2, 2026

Linear Story

We are migrating global properties outside of application helm-chart.
This is the second iteration.

The desired status is this one:

  • <app>-aws-secret-application (application helm-chart)
  • <app>-aws-parameter-store (application helm-chart)
  • global-aws-secret (flux-config)
  • global-aws-parameter-store (flux-config)

@linear
Copy link
Copy Markdown

linear Bot commented Apr 2, 2026

@vmarlier vmarlier marked this pull request as ready for review April 3, 2026 11:44
Copilot AI review requested due to automatic review settings April 3, 2026 11:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes migration “2/2” by removing support for the legacy aws-secret volume approach and aligning local fixtures/runtime wiring with the new split between application-scoped and global (flux-config) config sources.

Changes:

  • Removes legacy test/fixture/volumes/aws-secret/* fixtures and removes several fixtures from the application-scoped aws-parameter-store fixture set that are now treated as global.
  • Updates parse-config.sh to document the 4-source layout and to stop loading $WORKDIR/aws-secret (legacy path), while continuing to load application and global sources.
  • Updates docker-compose.yml to stop mounting the legacy $WORKDIR/aws-secret fixture volume.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
parse-config.sh Drops loading of legacy $WORKDIR/aws-secret and updates inline documentation to reflect the 4 directories (app + global).
docker-compose.yml Removes the legacy aws-secret fixture mount; keeps mounts for app-scoped and global volumes.
test/fixture/volumes/aws-secret/with_special_chars Removes legacy secret fixture file (old approach).
test/fixture/volumes/aws-secret/infrastructure_private.terraform Removes legacy secret fixture file (old approach).
test/fixture/volumes/aws-secret/infrastructure_openai_key Removes legacy secret fixture file (old approach).
test/fixture/volumes/aws-secret/infrastructure_launch-darkly_key Removes legacy secret fixture file (old approach).
test/fixture/volumes/aws-secret/infrastructure_global_launch-darkly_key Removes legacy secret fixture file (old approach).
test/fixture/volumes/aws-secret/ignore_multiline Removes legacy multiline fixture file (old approach).
test/fixture/volumes/aws-parameter-store/_infrastructure_msk_endpoint Removes fixture from app-scoped parameter store set (now expected as global).
test/fixture/volumes/aws-parameter-store/_application_kerberos_redis_kerberos-authz_url Removes fixture from app-scoped parameter store set (now expected as global).
test/fixture/volumes/aws-parameter-store/_application_kerberos_authentication_allowed_issuers Removes fixture from app-scoped parameter store set (now expected as global).
test/fixture/volumes/aws-parameter-store/_application_global_kerberos_cache_kerberos-authz_url Removes fixture from app-scoped parameter store set (now expected as global).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vmarlier vmarlier requested review from rbailly-pleo and zbcon April 7, 2026 07:53
Copy link
Copy Markdown

@zbcon zbcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls leave me alone

@vmarlier vmarlier merged commit 9120b31 into main Apr 8, 2026
6 checks passed
@vmarlier vmarlier deleted the SRE-8899/second-iteration branch April 8, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants