Fix: Display actual test suite status instead of hardcoded 'PASSED'

[SpacePlushy]

Summary

Fixes #5183

The print_suite_footer function was hardcoding 'PASSED' for any non-error test suite status, causing SKIPPED test suites to incorrectly display as PASSED in the test footer.

Changes

Modified platformio/test/cli.py to use the actual test_suite.status.name with appropriate color coding via status.to_ansi_color().

Before:

click.style(test_suite.status.name, fg="red", bold=True)
if is_error
else click.style("PASSED", fg="green", bold=True)  # ← Hardcoded!

After:

status_color = "red" if is_error else test_suite.status.to_ansi_color()
click.style(test_suite.status.name, fg=status_color, bold=True)

Testing

Verified the fix correctly displays all status types:

• ✅ PASSED (green) - when all tests pass
• ✅ FAILED (red) - when tests fail
• ✅ ERRORED (red) - when tests error
• ✅ SKIPPED (yellow) - when tests are skipped

Reproduction

Created test suites with different statuses and verified footer output matches actual test execution results.

Before fix: Empty test suite showed [PASSED] in footer
After fix: Empty test suite correctly shows [SKIPPED] in footer

[ivankravets]

Could you provide a simple project to reproduce this issue?

[mahdirajaee]

Good fix. The original code had a clear bug: the else branch hardcoded click.style("PASSED", fg="green") regardless of the actual test_suite.status, which meant statuses like SKIPPED, WARNED, or any non-error state all displayed as "PASSED". The new code correctly uses test_suite.status.name for the label and delegates to test_suite.status.to_ansi_color() for the color, which properly handles all TestStatus enum variants.

The one thing I'd verify is the behavior of to_ansi_color() for every possible TestStatus value — if any status returns None or an unexpected value, click.style(fg=...) might raise or silently produce uncolored output. A quick check that TestStatus.SKIPPED.to_ansi_color() returns a valid click color string would be good to confirm. The is_error check is still used correctly for the bar styling via the separate is_error=is_error kwarg, so that concern is cleanly separated from the status label. Clean, minimal change that addresses the reported issue.

Note: the diff also includes unrelated changes to piobuild.py (handling -U MACRO flag formats) that seem to belong to a different PR or concern — might want to split those out to keep the commit focused.