Fix word completion tracker stalling on space-before-punctuation#4975
Open
dimamik wants to merge 1 commit into
Open
Fix word completion tracker stalling on space-before-punctuation#4975dimamik wants to merge 1 commit into
dimamik wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
French (and similar) typography puts a space before
?!:;, e.g. "Comment ça va ?".advance_by_alnumsstops at that space, so once the last word is spoken the cursor stalls just before the punctuation: the frame never reports complete and RTVI clients that commit on the completed status drop the caption.Snap the tts/user-facing cursors to end-of-text on completion, mirroring the existing llm_pos sweep. Only trailing non-alnum can remain at that point.
Without this, the sentence stays stuck as in-progress and is dropped once the next one starts, instead of committing as a finished caption.