Refactor filesystem and VCS config Effect usage#3148
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Contributor
|
🚀 Expo continuous deployment is ready!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
WorkspaceFileSystem.readFileto use the injected EffectFileSystemservice instead ofnode:fs/promisesinsideEffect.tryPromise.assert.VcsProjectConfigmanualJSON.parse/ schema guard withSchema.decodeUnknownOption(Schema.fromJsonString(...))and added invalid-config tests.Why
These are two small idiomatic Effect improvements that make the code easier to test with Effect layers and keep JSON decoding on the schema path while preserving existing behavior.
UI Changes
Not applicable; this is server/runtime code only.
Checklist
Validation
PATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" pnpm exec vp test run src/workspace/Layers/WorkspaceFileSystem.test.ts src/vcs/VcsProjectConfig.test.ts(fromapps/server): 2 files / 14 tests passedPATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" pnpm exec vp checkPATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" pnpm exec vp run typecheckNote
Refactor filesystem and VCS config to use Effect-native APIs
WorkspaceFileSystem.readFileto use the EffectFileSystemAPI instead ofnode:fs/promises, adding a 1 MiB truncation limit and NUL-byte binary file rejection.VcsProjectConfig.readConfiguredKindwithSchema.decodeUnknownOption, returning'auto'on malformed or schema-invalid config files.readFileerror paths (path escapes root, non-file target, binary detection), errors are now returned as successfulWorkspaceFileSystemErrorvalues rather than failed effects.Macroscope summarized 0160225.