Skip to content

[codex] fix T3 Connect waitlist modal outline#3123

Closed
StiensWout wants to merge 3 commits into
pingdotgg:mainfrom
StiensWout:fix/waitlist-modal-outline
Closed

[codex] fix T3 Connect waitlist modal outline#3123
StiensWout wants to merge 3 commits into
pingdotgg:mainfrom
StiensWout:fix/waitlist-modal-outline

Conversation

@StiensWout

@StiensWout StiensWout commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Fixes #3119.

Summary

  • Suppress focus outlines on the shared dialog popup container so the app-wide outline style does not draw a second modal outline.
  • Match the desktop T3 Connect waitlist dialog wrapper width to the Clerk-style card and hide wrapper chrome for the transparent modal shell.
  • Pass a scoped Clerk openWaitlist appearance override for the web path instead of changing provider-global Clerk styling.
  • Add focused browser coverage for the desktop waitlist success state, popup outline style, and wrapper/card geometry.

Root Cause

The desktop waitlist card was rendered inside a transparent dialog popup wrapper wider than the inner Clerk-style card. When that outer popup received focus, the global outline style could appear as a second right-side outline around the transparent wrapper.

##Before/After
image

image

Validation

  • cd apps/web && PATH="$HOME/.vite-plus/bin:$PATH" vp test run --project browser src/components/clerk/DesktopClerkWaitlist.browser.tsx
  • PATH="$HOME/.vite-plus/bin:$PATH" vp check
  • PATH="$HOME/.vite-plus/bin:$PATH" vp run --filter @t3tools/web typecheck
  • PATH="$HOME/.vite-plus/bin:$PATH" vp run --filter @t3tools/web test

Note

Low Risk
Visual/focus styling only for the waitlist and shared dialog popup; no auth or data-path changes.

Overview
Fixes a second focus outline around the T3 Connect waitlist by removing outlines on the shared dialog shell and aligning the desktop wrapper with the inner Clerk-style card.

DialogPopup now includes outline-none on the default popup styles so app-wide focus outlines do not ring the transparent wrapper. On desktop, the waitlist DialogPopup is tightened to max-w-[25rem], with outline-none and before:hidden so the shell matches the card width and does not show extra chrome. On web, clerk.openWaitlist() passes a scoped appearance.elements override (rootBox, cardBox, cardoutline-none) instead of changing global Clerk theming.

Reviewed by Cursor Bugbot for commit 6f0b13f. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix outline styling in T3 Connect waitlist modal

  • Passes a custom appearance config to clerk.openWaitlist() to apply outline-none on modal elements in the non-Electron path.
  • Updates the Electron DialogPopup usage to cap width at 25rem, suppress outlines, and hide the before pseudo-element.
  • Adds outline-none globally to dialog.tsx so all DialogPopup instances drop focus outlines.

Macroscope summarized 6f0b13f.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 669f9807-b730-45c0-bdd5-18570f35dc38

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jun 17, 2026
@StiensWout StiensWout marked this pull request as ready for review June 17, 2026 06:53
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 17, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Purely styling changes adding CSS classes to remove unwanted outlines from modal elements. No runtime behavior impact - only visual adjustments.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp macroscopeapp Bot dismissed their stale review June 19, 2026 05:54

Dismissing prior approval to re-evaluate 6f0b13f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Waitlist Stripe UI misalign

2 participants