[codex] fix T3 Connect waitlist modal outline#3123
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Purely styling changes adding CSS classes to remove unwanted outlines from modal elements. No runtime behavior impact - only visual adjustments. You can customize Macroscope's approvability policy. Learn more. |
Co-authored-by: Codex <codex@openai.com>
Dismissing prior approval to re-evaluate 6f0b13f
Fixes #3119.
Summary
openWaitlistappearance override for the web path instead of changing provider-global Clerk styling.Root Cause
The desktop waitlist card was rendered inside a transparent dialog popup wrapper wider than the inner Clerk-style card. When that outer popup received focus, the global outline style could appear as a second right-side outline around the transparent wrapper.
##Before/After

Validation
cd apps/web && PATH="$HOME/.vite-plus/bin:$PATH" vp test run --project browser src/components/clerk/DesktopClerkWaitlist.browser.tsxPATH="$HOME/.vite-plus/bin:$PATH" vp checkPATH="$HOME/.vite-plus/bin:$PATH" vp run --filter @t3tools/web typecheckPATH="$HOME/.vite-plus/bin:$PATH" vp run --filter @t3tools/web testNote
Low Risk
Visual/focus styling only for the waitlist and shared dialog popup; no auth or data-path changes.
Overview
Fixes a second focus outline around the T3 Connect waitlist by removing outlines on the shared dialog shell and aligning the desktop wrapper with the inner Clerk-style card.
DialogPopupnow includesoutline-noneon the default popup styles so app-wide focus outlines do not ring the transparent wrapper. On desktop, the waitlistDialogPopupis tightened tomax-w-[25rem], withoutline-noneandbefore:hiddenso the shell matches the card width and does not show extra chrome. On web,clerk.openWaitlist()passes a scopedappearance.elementsoverride (rootBox,cardBox,card→outline-none) instead of changing global Clerk theming.Reviewed by Cursor Bugbot for commit 6f0b13f. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix outline styling in T3 Connect waitlist modal
appearanceconfig toclerk.openWaitlist()to applyoutline-noneon modal elements in the non-Electron path.DialogPopupusage to cap width at25rem, suppress outlines, and hide thebeforepseudo-element.outline-noneglobally to dialog.tsx so allDialogPopupinstances drop focus outlines.Macroscope summarized 6f0b13f.