feat(sidebar): worktree indicator on session rows#3057
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 55144b2. Configure here.
|
|
||
| rmSync(targetAppBundlePath, { recursive: true, force: true }); | ||
| cpSync(sourceAppBundlePath, targetAppBundlePath, { recursive: true }); | ||
| // verbatimSymlinks keeps the framework's relative symlinks intact |
There was a problem hiding this comment.
Cached bundle skips symlink fix
Medium Severity
buildMacLauncher now copies with verbatimSymlinks, but when an existing .electron-runtime bundle matches metadata.json, it returns that copy without rebuilding. Upgrades from a broken staged bundle keep the old absolute symlinks, so pnpm start:desktop on macOS can still hit ICU/GPU helper crashes until .electron-runtime is deleted manually.
Reviewed by Cursor Bugbot for commit 55144b2. Configure here.
There was a problem hiding this comment.
This finding refers to the launcher change, which has been split out of this PR into #3058. It is addressed there: LAUNCHER_VERSION is bumped so previously staged bundles with rewritten symlinks are invalidated and re-copied instead of being reused by the metadata check. This PR is now sidebar-only.
ApprovabilityVerdict: Approved Simple UI addition that displays a worktree indicator icon on sidebar session rows. The component is purely presentational with no business logic changes, and includes test coverage. The unresolved review comment references a file not modified by this PR. You can customize Macroscope's approvability policy. Learn more. |
55144b2 to
53e6269
Compare
Sessions running in a git worktree show a FolderGit2 icon in the trailing status cluster, with the worktree folder and branch in an accessible tooltip label. Add focused render coverage for visible and absent worktree paths. Co-authored-by: codex <codex@users.noreply.github.com>
53e6269 to
25773fd
Compare


Sessions running in a git worktree now show a small FolderGit2 icon in the sidebar row, next to the terminal-status icon, with a tooltip giving the worktree folder and branch. This makes worktree sessions distinguishable from main-checkout sessions at a glance.
Detection uses the existing
thread.worktreePath, no extra git calls. The indicator sits in the row's right-side cluster rather than inside the timestamp/meta span, because that span ispointer-events-noneand fades on row hover, which makes tooltips there unreachable.Tooltip on hover:
Verified in a live session with real worktree threads (screenshots above).
vp checkand typecheck pass.🤖 Generated with Claude Code
Note
Low Risk
Small, read-only UI change driven by existing thread metadata; no new git calls or backend behavior.
Overview
Sidebar session rows now show a worktree indicator when
thread.worktreePathis set, so worktree sessions are visually distinct from main-checkout sessions.A new
ThreadWorktreeIndicatorrenders aFolderGit2icon with a tooltip (formatted folder viaformatWorktreePathForDisplay, plus branch when present) and an accessiblearia-label. It is placed in the row’s right-side icon cluster inSidebarThreadRow—alongside preview port and terminal status—rather than in the timestamp/meta area that usespointer-events-noneand fades on hover.Coverage is added in
ThreadStatusIndicators.test.tsxfor the accessible label and for hiding the indicator when the worktree path is missing or whitespace-only.Reviewed by Cursor Bugbot for commit 25773fd. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add worktree indicator icon to sidebar session rows
Adds a new
ThreadWorktreeIndicatorcomponent in ThreadStatusIndicators.tsx that renders aFolderGit2Iconwith an accessible tooltip showing the formatted worktree path and branch. The indicator is inserted into the thread row actions area in Sidebar.tsx and renders nothing whenworktreePathis absent or whitespace.Macroscope summarized 25773fd.