Skip to content

deps,version: bump client-go for nextgen 202603#5311

Open
wfxr wants to merge 2 commits into
pingcap:release-nextgen-202603from
wfxr:wfxr/release-nextgen-202603-fix
Open

deps,version: bump client-go for nextgen 202603#5311
wfxr wants to merge 2 commits into
pingcap:release-nextgen-202603from
wfxr:wfxr/release-nextgen-202603-fix

Conversation

@wfxr

@wfxr wfxr commented Jun 10, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: ref #5206

This is a release-nextgen-202603 follow-up to #5205.

The release-nextgen-202603 branch needs to consume the latest TiCDC-specific github.com/tikv/client-go/v2 branch revision for nextgen shared-lock related fixes: tikv/client-go#2000

The branch also needs the TiKV compatibility upper bound aligned with the nextgen release version range.

What is changed and how it works?

  • Bump github.com/tikv/client-go/v2 from v2.0.8-0.20260609065146-a68b42e6aab4 to v2.0.8-0.20260610130222-a41cab3aaf31.
  • Update go.sum with the new client-go checksum.
  • Raise maxTiKVVersion from 15.0.0 to 26.4.0.

Check List

Tests

  • Unit test
  • Manual test

Local checks run:

  • go mod tidy
  • git diff --check upstream/release-nextgen-202603..HEAD
  • GOCACHE=/tmp/ticdc-go-cache go test ./pkg/version
  • GOCACHE=/tmp/ticdc-go-cache make cdc

Questions

Will it cause performance regression or break compatibility?

No expected performance regression. The dependency bump is limited to the TiCDC-specific client-go branch for nextgen shared-lock fixes, and the version compatibility bound is adjusted for the nextgen release range.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None.

wfxr added 2 commits June 10, 2026 21:20
Bump client-go to the latest release-nextgen-202603-ticdc.
Raise the maximum compatible TiKV version boundary to 26.4.0 for the
nextgen release branch.
@ti-chi-bot ti-chi-bot Bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 3aceshowhand for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6f2b8076-5837-48c5-b96e-4d6e61b9f083

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pingcap-cla-assistant

pingcap-cla-assistant Bot commented Jun 10, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the github.com/tikv/client-go/v2 dependency in go.mod and go.sum. Additionally, it increases the maximum compatible TiKV version (maxTiKVVersion) from 15.0.0 to 26.4.0 in pkg/version/check.go. There are no review comments to address, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@wfxr

wfxr commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

/test next-gen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant