Skip to content

go.mod: upgrade tiflow to support partial index and add related tests (#3699)#5299

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:release-8.5from
YangKeao:yangkeao/release-8.5-partial-index
Jun 11, 2026
Merged

go.mod: upgrade tiflow to support partial index and add related tests (#3699)#5299
ti-chi-bot[bot] merged 2 commits into
pingcap:release-8.5from
YangKeao:yangkeao/release-8.5-partial-index

Conversation

@YangKeao

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #3698

What is changed and how it works?

Upgrade the TiCDC to support partial index.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

It's manually tested with https://github.com/PingCAP-QE/endless/pull/3072.

Questions

Will it cause performance regression or break compatibility?

This is a manual cherry pick of #3699

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Summary by CodeRabbit

  • Chores

    • Updated dependencies: go-mysql to v1.13.0, tidb/tiflow to a newer revision, and adjusted gRPC to v1.65.0.
  • Tests

    • Added integration tests covering partial index creation and data scenarios.
    • Added test runner and configuration to validate partial-index behavior.
    • Expanded CI test matrix to include partial_index across all sink types.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jun 10, 2026
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@ti-chi-bot ti-chi-bot Bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 85116264-e572-4275-a634-ee3edb93090d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 10, 2026
@YangKeao

Copy link
Copy Markdown
Member Author

Ref pingcap/tiflow#12686, not finished yet.
/hold

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2026
@YangKeao YangKeao marked this pull request as draft June 10, 2026 06:40
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2026
@YangKeao YangKeao marked this pull request as ready for review June 10, 2026 17:28
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2026
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hongyunyan,wk989898]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-06-11 01:08:36.694093195 +0000 UTC m=+1008617.764410585: ☑️ agreed by hongyunyan.
  • 2026-06-11 01:26:53.529656769 +0000 UTC m=+1009714.599974159: ☑️ agreed by wk989898.

@wk989898 wk989898 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2026
@ti-chi-bot ti-chi-bot Bot merged commit dcbff28 into pingcap:release-8.5 Jun 11, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants