schemastore: support ActionCreateMaterializedView (#4779)#5229
Conversation
* wip * add more log * add more log * f * fix * fix * fix * add more test * add some log * support create mv * try fix * f * f * fix * fix * fix * fix * add comment
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces support for tracking materialized views and handling their out-of-place refresh cutovers. Key changes include adding methods to retrieve materialized view IDs, updating table trigger DDL event fetching to track materialized view lineages, and introducing a local DDL event type for cutovers in the filter package. The review feedback highlights two important issues: first, mutating the trackedMaterializedViewIDs map in-place during event fetching makes the operation non-idempotent and can lead to silently skipped events on retries; second, a potential nil pointer dereference exists when accessing the database map in loadMaterializedViewIDsAtTs without verifying if the schema ID is present.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini summary |
Summary of ChangesThis pull request enables TiCDC to support the ActionCreateMaterializedView DDL operation. It integrates the necessary logic to persist these events, ensures they are correctly handled by the schema store, and updates the filtering framework to accommodate materialized view refresh operations. These changes ensure that materialized views are properly tracked and processed within the replication pipeline. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Activity
|
Summary of ChangesThis pull request introduces support for ActionCreateMaterializedView within the schema store, ensuring that materialized view creation events are correctly persisted and handled. It also includes updates to the DDL filtering logic to accommodate materialized view-specific events, such as out-of-place refresh cutovers, and adds robust unit testing to verify these new capabilities. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Activity
|
5445ede
into
pingcap:feature/release-8.5-materialized-view
What problem does this PR solve?
Issue Number: close #5183
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note