add SSL connection check option#1107
Open
TatevikGr wants to merge 2 commits into
Open
Conversation
TatevikGr
force-pushed
the
ssl_mysql_connection
branch
2 times, most recently
from
ddea17a to
24ff6bb
Compare
TatevikGr
force-pushed
the
ssl_mysql_connection
branch
from
24ff6bb to
a5ef244
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds configurable MySQL SSL/TLS connection behavior for phpList’s mysqli database connection layer while documenting the new settings in the extended config.
Changes:
- Adds
$database_connection_ssl_forceto useMYSQLI_CLIENT_SSL. - Adds
$database_connection_ssl_cahandling viamysqli_ssl_set(). - Updates extended configuration comments for SSL/TLS database settings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
public_html/lists/admin/mysqli.inc |
Applies new SSL flags and optional CA configuration during mysqli connection setup. |
public_html/lists/config/config_extended.php |
Documents the new SSL force and CA configuration options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // If the database user requires SSL, set this to the path | ||
| // of the CA certificate used to verify the MySQL server certificate. | ||
| $database_connection_ssl_ca = '/path/to/ca.pem'; |
Comment on lines
+34
to
+43
| if (!empty($database_connection_ssl_ca)) { | ||
| mysqli_ssl_set( | ||
| $db, | ||
| null, | ||
| null, | ||
| realpath($database_connection_ssl_ca), | ||
| null, | ||
| null | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Related Issue
issue
Screenshots (if appropriate):