main/poll: Cap kqueue grouped-event buffer write at runtime#22327
Open
iliaal wants to merge 1 commit into
Open
main/poll: Cap kqueue grouped-event buffer write at runtime#22327iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
The kqueue grouped-event path bounded the result buffer only with a ZEND_ASSERT, allowing an out-of-bounds write in release builds when more distinct descriptors were ready than the caller's maxEvents. Cap the buffer write at runtime while still running the oneshot bookkeeping so the backend's tracking stays in sync. Closes phpGH-22327
iliaal
force-pushed
the
fix/poll-kqueue-buffer-cap
branch
from
1ac6729 to
5508243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kqueue grouped-event path bounded the result buffer only with a
ZEND_ASSERT, allowing an out-of-bounds write in release builds when more distinct descriptors were ready than the caller'smaxEvents. This caps the buffer write at runtime while still running the oneshot bookkeeping so the backend's tracking stays in sync. An alternative is to cap thekevent()request tomaxEventsso the dedup can't exceed the buffer; this takes the minimal in-place fix. kqueue isn't compiled on Linux, so it rides macOS CI. Split out of #22316 on review.