main/poll: Record wait() error on every backend#22326
Open
iliaal wants to merge 1 commit into
Open
Conversation
php_poll_wait() reported a stale error code when a backend's wait syscall failed without recording one: epoll, poll and kqueue returned -1 without setting it. Record it from errno in those backends so php_poll_get_error() reflects the actual failure. eventport and wsapoll already did, the latter from WSAGetLastError(). Closes phpGH-22326
iliaal
force-pushed
the
fix/poll-wait-error-recording
branch
from
c8d8034 to
2ac5e47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_poll_wait()reported a stale error code when a backend's wait syscall failed without recording one. epoll, poll and kqueue returned -1 without setting it, so record it from errno andphp_poll_get_error()then reflects the real failure. eventport and wsapoll already did this, the latter fromWSAGetLastError(). Split out of #22316 on review.