zend_ast: Always print encaps list variables with braces when exporting AST#22293
Merged
Merged
Conversation
…ng AST
The `"{$foo}"` variant of interpolating variables into a string is the only one
that reliably works all the time. Always use it for simplicity.
Fixes php#22291.
TimWolla
changed the title
Girgias
approved these changes
Jun 14, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
I'm fine with this, but others may have a different opinion.
iluuu1994
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
"{$foo}"variant of interpolating variables into a string is the only one that reliably works all the time. Always use it for simplicity.Fixes #22291.