Skip to content

enumerations.xml Amend the CS of the code examples#4088

Open
mmalferov wants to merge 4 commits intophp:masterfrom
mmalferov:patch-996250
Open

enumerations.xml Amend the CS of the code examples#4088
mmalferov wants to merge 4 commits intophp:masterfrom
mmalferov:patch-996250

Conversation

@mmalferov
Copy link
Copy Markdown
Member

No description provided.

Comment thread language/enumerations.xml Outdated
@tiffany-taylor
Copy link
Copy Markdown
Member

Changes in this PR are made to the pages in this section: https://www.php.net/manual/en/language.enumerations.php

I was guided by the reader and how convenient it would be for the user to read the example. I'm going back to the previous formatting, since it violates the tradition :)
@vrana
Copy link
Copy Markdown
Contributor

vrana commented Apr 24, 2025

I see no point in adding newlines before ?>.

@Crell
Copy link
Copy Markdown
Contributor

Crell commented Oct 3, 2025

Please remove the newlines before ?>, as we don't need those, and rebase the PR. We should be able to merge it then. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants